fix(udp/windows): set socket option IPV6_RECVECN #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, to enable ECN reporting, one sets the `IPV6_RECVECN` socket option. The Windows IP stack will then report ECN markings via the `IPV6_ECN` message type. Previously `quinn-udp` would use `IPV6_ECN` for both. With this commit `IPV6_RECVECN` is used to set the socket option and `IPV6_ECN` is used to read the option. Given that both constants evaluate to the same value (i.e. `50`) the previous behavior does not result in an actual bug. See also: - https://learn.microsoft.com/en-us/windows/win32/winsock/ipproto-ipv6-socket-options - https://www.ietf.org/archive/id/draft-duke-tsvwg-udp-ecn-01.html - https://docs.rs/windows-sys/latest/windows_sys/Win32/Networking/WinSock/constant.IPV6_RECVECN.html - https://docs.rs/windows-sys/latest/windows_sys/Win32/Networking/WinSock/constant.IPV6_ECN.html
Ralith
approved these changes
Jan 5, 2025
mxinden
added a commit
to mxinden/quinn
that referenced
this pull request
Jan 6, 2025
Equivalent to quinn-rs#2125 for IPv4. On Windows, to enable ECN reporting on IPv4, one sets the `IP_RECVECN` socket option. The Windows IP stack will then report ECN markings via the `IP_ECN` message type. Previously `quinn-udp` would use `IP_ECN` for both. With this commit `IP_RECVECN` is used to set the socket option and `IP_ECN` is used to read the option. Given that both constants evaluate to the same value (i.e. `50`) the previous behavior does not result in an actual bug. See also: - https://learn.microsoft.com/en-us/windows/win32/winsock/ipproto-ipv6-socket-options - https://www.ietf.org/archive/id/draft-duke-tsvwg-udp-ecn-01.html - https://docs.rs/windows-sys/latest/windows_sys/Win32/Networking/WinSock/constant.IP_RECVECN.html - https://docs.rs/windows-sys/latest/windows_sys/Win32/Networking/WinSock/constant.IP_ECN.html
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
Equivalent to #2125 for IPv4. On Windows, to enable ECN reporting on IPv4, one sets the `IP_RECVECN` socket option. The Windows IP stack will then report ECN markings via the `IP_ECN` message type. Previously `quinn-udp` would use `IP_ECN` for both. With this commit `IP_RECVECN` is used to set the socket option and `IP_ECN` is used to read the option. Given that both constants evaluate to the same value (i.e. `50`) the previous behavior does not result in an actual bug. See also: - https://learn.microsoft.com/en-us/windows/win32/winsock/ipproto-ipv6-socket-options - https://www.ietf.org/archive/id/draft-duke-tsvwg-udp-ecn-01.html - https://docs.rs/windows-sys/latest/windows_sys/Win32/Networking/WinSock/constant.IP_RECVECN.html - https://docs.rs/windows-sys/latest/windows_sys/Win32/Networking/WinSock/constant.IP_ECN.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, to enable ECN reporting, one sets the
IPV6_RECVECNsocket option. The Windows IP stack will then report ECN markings via theIPV6_ECNmessage type.Previously
quinn-udpwould useIPV6_ECNfor both. With this commitIPV6_RECVECNis used to set the socket option andIPV6_ECNis used to read the option.Given that both constants evaluate to the same value (i.e.
50) the previous behavior does not result in an actual bug.See also: