Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two inlines slowing down GLTF TTFX on Julia v1.10.3 and bloating compiled dll sizes on Julia v1.10 and v1.11 #282

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jaakkor2
Copy link
Contributor

@jaakkor2 jaakkor2 commented Jun 4, 2024

Remove two inlines slowing down GLTF TTFX on Julia v1.10.3 and bloating compiled dll sizes on Julia v1.10 and v1.11.
Fixes #279.

Before

v1.10.3

@time using GLTF; @time load(joinpath(pkgdir(GLTF), "assets", "DamagedHelmet.gltf"));
  0.122459 seconds (109.06 k allocations: 7.716 MiB)
  5.278717 seconds (3.35 M allocations: 166.804 MiB, 0.44% gc time, 99.99% compilation time)

6TsRJ_9EZ8v.dll 41 MB

v1.11.0-beta2

@time using GLTF; @time load(joinpath(pkgdir(GLTF), "assets", "DamagedHelmet.gltf"));
  0.205132 seconds (139.25 k allocations: 8.620 MiB)
  0.000295 seconds (459 allocations: 27.164 KiB)

6TsRJ_6Xhya.dll 201 MB

After

v1.10.3

@time using GLTF; @time load(joinpath(pkgdir(GLTF), "assets", "DamagedHelmet.gltf"));
  0.112920 seconds (97.59 k allocations: 7.255 MiB)
  0.382297 seconds (688.95 k allocations: 50.071 MiB, 2.85% gc time, 99.85% compilation time)

6TsRJ_bCVAr.dll 16 MB

v1.11.0-beta2

@time using GLTF; @time load(joinpath(pkgdir(GLTF), "assets", "DamagedHelmet.gltf"));
  0.211747 seconds (139.25 k allocations: 8.619 MiB)
  0.000334 seconds (459 allocations: 27.164 KiB)

6TsRJ_1Irey.dll 32 MB

@jaakkor2
Copy link
Contributor Author

Gentle ping @quinnj

@jaakkor2
Copy link
Contributor Author

jaakkor2 commented Aug 5, 2024

Another gentle ping @quinnj

Copy link
Owner

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quinnj quinnj merged commit 5e4717e into quinnj:main Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@inline-statements in src/structs.jl seem to bloat the precompiled size and slow TTFX
2 participants