Open
Conversation
aaccensi
reviewed
Mar 2, 2026
Contributor
aaccensi
left a comment
There was a problem hiding this comment.
Overall the process is good. I only saw:
- A few text references that are not the actual exact labels.
- A couple of clarifications regarding what the scenarios in the import contain.
Collaborator
Author
Thanks for looking this over @aaccensi! I've processed the suggestions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Extend myetm readme to cover local database set up and import-scenarios usage.
Implemented changes
Extended the readme to outline:
bin/import-scenarioscommand to import scenarios from beta/pro locallyChecklist
The truest way to test this is by turning dbbot off except for ETLocal, and to test the instructions with a new employee who is setting up for the first time.
Alternatively someone could spend some time dropping all their local dbs and testing the set up from scratch.
@aaccensi I tagged you in case you can spot something I've missed
@mabijkerk I tagged you for functional review - feel free to reassign if you think someone else would be better suited or has more time