fix(twitter-url): twitter vernacular url encode bug #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivteck
changed the title
EnKrypt
approved these changes
Sep 24, 2021
Athira001
reviewed
Sep 25, 2021
| return React.createElement(this.props.template, Object.assign({ | ||
| fbUrl: `https://www.facebook.com/sharer.php?u=${encodeURIComponent(fullUrl)}`, | ||
| twitterUrl: `https://twitter.com/intent/tweet?url=${encodeURIComponent(fullUrl)}&text=${encodeURIComponent(this.props.title)}&hashtags=${hashtags}`, | ||
| twitterUrl: `https://twitter.com/intent/tweet?url=${encodeURI(fullUrl)}&text=${encodeURIComponent(this.props.title)}&hashtags=${hashtags}`, |
Contributor
There was a problem hiding this comment.
We can pass the encoded Url from the app level?
<SocialShare
template={ShareAllTemplate}
title={storyData.headline}
fullUrl={encodeURI(story.url)}
/>
Contributor
Author
There was a problem hiding this comment.
because it is easier to fix in the implementation level rather than modifying ever use case in the app level
Contributor
There was a problem hiding this comment.
Currently, Prothomalo and Prabhatkbhar, They already passing it in encoded form. @sivteck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there is vernacular text in the shared article url, twitter breaks the output from
encodeURIComponent, see the linked issue for descriptionFixes https://github.com/quintype/madrid/issues/4105
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
The fix is to just use
encodeURIfunction insteadDifferences between these functions are documented here,
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent#description
Checklist: