build: add back loader parameter to node commands

Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

Additionally, as `--loader` is deprecated, an error message
suggests to do in JavaScript, so add a loader script
`--import ./loader.js` to do this work instead

Fixes #5910.
Fixes #5989.

.mocharc.cjs

@@ -9,6 +9,7 @@ module.exports = {
     'test/helper/*',
   ],
   loader: [
+    // TODO: figure out how to do something like ./loader.js for mocha.
     'ts-node/esm',
   ],
   extension: [

CONTRIBUTING.md

@@ -76,14 +76,21 @@ and on the server-side (GitHub).
 You will need to [install](README.md#npm-and-webpack) `nodejs` and run `npm install`
 in order to install local versions of husky, lint-staged, and eslint.
 
-It is recommended that you also install ts-node and typescript globally, e.g.
+It is recommended that you also install typescript globally, e.g.
 
 ```shell
 npm install -g typescript
-npm install -g ts-node
 ```
 
-This will let you run commands as `ts-node` directly instead of `npx ts-node`.
+Most commands have npm versions of them, e.g. `npm test` or `npm lint`
+If you need to run a typescript file on its own, with Node v20 and later
+you must pass an additional loader parameter.
+Either of the following work for now:
+
+```shell
+node --import ./loader.js util/sync_files.ts
+node --loader=ts-node/esm util/sync_files.ts
+```
 
 If the pre-commit validations are causing you significant problems,
 feel free to bypass the checks with `--no-verify` flag,

README.md

@@ -178,7 +178,7 @@ To install dependencies there are 2 methods: **per script** and **manually**
 ### Dependencies: Script Method
 
 1. `curl` MUST be installed (this is used to download dependencies)
-1. Execute `ts-node ./util/fetch_deps.ts` script
+1. Execute `node --import ./loader.js util/fetch_deps.ts` script
 1. Continue with **Steps to build**
 
 ### Dependencies: Manual Method

docs/PatchUpdateChecklist.md

@@ -64,9 +64,9 @@ python util/gen_zone_id_and_info.py
 python util/gen_weather_rate.py
 python util/gen_hunt_data.py
 
-ts-node util/gen_effect_id.ts
-ts-node util/gen_world_ids.ts
-ts-node util/gen_pet_names.ts
+node --import ./loader.js util/gen_effect_id.ts
+node --import ./loader.js util/gen_world_ids.ts
+node --import ./loader.js util/gen_pet_names.ts
 ```
 
 Here's an example: <https://github.com/quisquous/cactbot/pull/5823/files>

docs/TimelineGuide.md

@@ -412,7 +412,7 @@ For example, in this fight, these are the relevant log lines and times:
 You can then make a timeline from those times by running the following command.
 
 ```bash
-ts-node util/logtools/make_timeline.ts -f CapeWestwind.log -s 18:42:23.614 -e 18:49:22.934
+node --import ./loader.js util/logtools/make_timeline.ts -f CapeWestwind.log -s 18:42:23.614 -e 18:49:22.934
 
 0 "Start"
 2.0 "Shield Skewer" sync /:Rhitahtyn sas Arvina:471:/
@@ -508,7 +508,7 @@ ts-node util/logtools/make_timeline.ts -f CapeWestwind.log -s 18:42:23.614 -e 18
 (Note that you can also use the `-lf` parameter to list the encounters in the combat log.
 
 ```bash
-ts-node util/logtools/make_timeline.ts -f CapeWestwind.log -lf
+node --import ./loader.js util/logtools/make_timeline.ts -f CapeWestwind.log -lf
 
 ┌───────┬──────────────┬────────────────┬──────────┬─────────────────────────────────────────┬─────────────────────────────────────────┬───────────────┐
 │ Index │  Start Date  │   Start Time   │ Duration │                Zone Name                │             Encounter Name              │   End Type    │
@@ -543,14 +543,14 @@ Most of the time, you can't count on adds to have reliable
 timing relative to the main boss, so it's usually better to
 remove them.
 
-The ts-node util/logtools/make_timeline.ts script has two options to do this.
+The `node --import ./loader.js util/logtools/make_timeline.ts` script has two options to do this.
 One is "ignore combatants" and the other is "ignore id".
 Either `-ic "7Th Cohort Optio"` or `-ii 0A 2CD 2CE 194 14`
 will remove all of these abilities.
 We'll go with ids.
 
 Run the command again with this ignore to have a cleaned up version:
-`ts-node util/logtools/make_timeline.ts -f CapeWestwind.log -s 18:42:23.614 -e 18:49:22.934 -ii 0A 2CD 2CE 194 14`
+`node --import ./loader.js util/logtools/make_timeline.ts -f CapeWestwind.log -s 18:42:23.614 -e 18:49:22.934 -ii 0A 2CD 2CE 194 14`
 
 At this point, it may also be worth going through and finding other lines to add.
 Usually, these are [added combatant](LogGuide.md#line-03-0x03-addcombatant) lines
@@ -681,7 +681,7 @@ let's adjust the first usage of `Shrapnel Shell`
 so here we would write it as `-p 474:204.3`.
 
 Here's the new command line we've built up to:
-`ts-node util/logtools/make_timeline.ts -f CapeWestwind.log -s 18:42:23.614 -e 18:49:22.934 -ii 0A 2CD 2CE 194 14 -p 474:204.3`
+`node --import ./loader.js util/logtools/make_timeline.ts -f CapeWestwind.log -s 18:42:23.614 -e 18:49:22.934 -ii 0A 2CD 2CE 194 14 -p 474:204.3`
 
 This gets us the following output for phase 2,
 with manually added blank lines to break out the loops.
@@ -881,7 +881,7 @@ Let's start phase 4 at 600 seconds, so we'll adjust the
 first use of `Magitek Missile` (ability id 478) to be t=610.
 
 Here's the final command line, including this second phase:
-`ts-node util/logtools/make_timeline.ts -f CapeWestwind.log -s 18:42:23.614 -e 18:49:22.934 -ii 0A 2CD 2CE 194 14 -p 474:204.3 478:610`
+`node --import ./loader.js util/logtools/make_timeline.ts -f CapeWestwind.log -s 18:42:23.614 -e 18:49:22.934 -ii 0A 2CD 2CE 194 14 -p 474:204.3 478:610`
 
 ```bash
 # manually added in
@@ -1216,7 +1216,7 @@ in the **ui/raidboss/data/timelines** folder, minus the .txt extension.
 (As with `make_timeline`, you can use the `-lf` parameter to list encounters.)
 
 ```bash
-$ ts-node util/logtools/test_timeline.ts -f CapeWestwind.log -s 18:42:23.614 -e 18:49:22.934 -t cape_westwind
+$ node --import ./loader.js util/logtools/test_timeline.ts -f CapeWestwind.log -s 18:42:23.614 -e 18:49:22.934 -t cape_westwind
 0.000: Matched entry: 2.0 Shield Skewer (+2.000s)
 10.556: Matched entry: 10.6 Shield Skewer (+0.044s)
 18.985: Matched entry: 19.0 Shield Skewer (+0.015s)
@@ -1367,7 +1367,7 @@ The new time will be 595 - 10.7 = 584.3.
 Rerunning the tester (most output omitted)
 
 ```bash
-$ ts-node util/logtools/test_timeline.ts -f CapeWestwind.log -s 18:42:23.614 -e 18:49:22.
+$ node --import ./loader.js util/logtools/test_timeline.ts -f CapeWestwind.log -s 18:42:23.614 -e 18:49:22.
 934 -t cape_westwind
 
 431.400: Matched entry: 584.3 --sync-- (+152.900s)
@@ -1390,7 +1390,7 @@ but `Shrapnel Shell` is now in the right spot.
 It's important to test against multiple fight instances to make sure that the timeline is good.
 Here's an example of running against the **CapeWestwind2.log** file.
 
-If you run `ts-node util/logtools/test_timeline.ts -f CapeWestwind2.log -s 13:21:00.688 -e 13:29:36.976 -t cape_westwind` yourself, you can spot at least two problems.
+If you run `node --import ./loader.js util/logtools/test_timeline.ts -f CapeWestwind2.log -s 13:21:00.688 -e 13:29:36.976 -t cape_westwind` yourself, you can spot at least two problems.
 
 One minor problem is that this boss is inconsistent:
 

docs/ko-KR/README.md

@@ -174,7 +174,7 @@ cactbot은 테스트 UI를 기본으로 제공합니다.
 ### 의존성 설치: 스크립트 방식
 
 1. `curl`이 반드시 설치되어 있어야 합니다. (의존성 파일들을 다운로드하기 위해 사용됩니다.)
-1. `ts-node ./util/fetch_deps.ts` 스크립트를 실행하세요.
+1. `node --import ./loader.js ./util/fetch_deps.ts` 스크립트를 실행하세요.
 1. **빌드하는 단계**로 이동하세요.
 
 ### 의존성 설치: 수동

docs/zh-CN/README.md

@@ -145,7 +145,7 @@ cactbot 提供以下模块：
 ### 安装依赖：脚本方式
 
 1. 必须先安装 `curl`（用于下载依赖项）
-1. 运行 `ts-node ./util/fetch_deps.ts` 脚本
+1. 运行 `node --import ./loader.js ./util/fetch_deps.ts` 脚本
 1. 下转 **构建步骤**
 
 ### 安装依赖：手动方式

loader.js

@@ -0,0 +1,5 @@
+import { register } from 'node:module';
+import url from 'node:url';
+
+const __filename = url.fileURLToPath(import.meta.url);
+register('ts-node/esm', url.pathToFileURL(__filename));

package.json

@@ -19,7 +19,7 @@
     "build": "webpack --progress --config webpack/webpack.prod.ts",
     "build-gh-pages": " webpack --config webpack/webpack.ghpages.ts",
     "start": "webpack serve --config webpack/webpack.dev.ts",
-    "fetch-deps": "ts-node ./util/fetch_deps.ts",
+    "fetch-deps": "node --import ./loader.js ./util/fetch_deps.ts",
     "tsc-no-emit": "tsc --noEmit",
     "lint": "run-s lint:**",
     "lint:dprint": "dprint check",
@@ -31,17 +31,17 @@
     "stylelintfix": "stylelint --fix \"resources/**/*.css\" \"ui/**/*.css\" \"user/**/*.css\" \"test/**/*.css\" \"util/**/*.css\"",
     "markdownlint": "markdownlint . --ignore node_modules --ignore publish --ignore plugin/ThirdParty",
     "test": "mocha",
-    "sync-files": "ts-node util/sync_files.ts && git diff --exit-code",
+    "sync-files": "node --import ./loader.js util/sync_files.ts && git diff --exit-code",
     "lint-staged": "lint-staged",
-    "coverage-report": "ts-node util/gen_coverage_report.ts",
-    "util": "ts-node util/index.ts",
+    "coverage-report": "node --import ./loader.js util/gen_coverage_report.ts",
+    "util": "node --import ./loader.js util/index.ts",
     "find-translations": "npm run util -- findTranslations",
     "translate-timeline": "npm run util -- translateTimeline",
     "generate": "npm run util -- generate",
-    "process-triggers": "ts-node util/process_triggers_folder.ts",
-    "generate-log-guide": "ts-node util/gen_log_guide.ts",
-    "validate-versions": "ts-node util/validate_versions.ts",
-    "version": "ts-node util/bump_version.ts"
+    "process-triggers": "node --import ./loader.js util/process_triggers_folder.ts",
+    "generate-log-guide": "node --import ./loader.js util/gen_log_guide.ts",
+    "validate-versions": "node --import ./loader.js util/validate_versions.ts",
+    "version": "node --import ./loader.js util/bump_version.ts"
   },
   "devDependencies": {
     "@actions/exec": "^1.1.1",
@@ -121,7 +121,7 @@
     "webpack-merge": "^5.8.0"
   },
   "engines": {
-    "node": ">=18.10.0 <=18.18.2"
+    "node": ">=20.10.0"
   },
   "stylelint": {
     "extends": "stylelint-config-standard"
@@ -145,7 +145,7 @@
     "*.md": "markdownlint",
     "*.py": "python -m pylint --errors-only",
     "ui/(raidboss|oopsyraidsy)/data/**": [
-      "ts-node test/test_data_files.ts"
+      "node --import ./loader.js test/test_data_files.ts"
     ]
   },
   "dependencies": {

ui/oopsyraidsy/data/06-ew/dungeon/another_mount_rokkon-savage.ts

@@ -1,4 +1,4 @@
-// This file was autogenerated from running ts-node util/sync_files.ts.
+// This file was autogenerated from running npm run sync-files.
 // DO NOT EDIT THIS FILE DIRECTLY.
 // Edit the source file below and then run `npm run sync-files`
 // Source: ui/oopsyraidsy/data/06-ew/dungeon/another_mount_rokkon.ts

ui/oopsyraidsy/data/06-ew/dungeon/another_sildihn_subterrane-savage.ts

@@ -1,4 +1,4 @@
-// This file was autogenerated from running ts-node util/sync_files.ts.
+// This file was autogenerated from running npm run sync-files.
 // DO NOT EDIT THIS FILE DIRECTLY.
 // Edit the source file below and then run `npm run sync-files`
 // Source: ui/oopsyraidsy/data/06-ew/dungeon/another_sildihn_subterrane.ts

ui/oopsyraidsy/data/06-ew/trial/sophia-un.ts

@@ -1,4 +1,4 @@
-// This file was autogenerated from running ts-node util/sync_files.ts.
+// This file was autogenerated from running npm run sync-files.
 // DO NOT EDIT THIS FILE DIRECTLY.
 // Edit the source file below and then run `npm run sync-files`
 // Source: ui/oopsyraidsy/data/03-hw/trial/sophia-ex.ts

ui/oopsyraidsy/data/06-ew/trial/thordan-un.ts

@@ -1,4 +1,4 @@
-// This file was autogenerated from running ts-node util/sync_files.ts.
+// This file was autogenerated from running npm run sync-files.
 // DO NOT EDIT THIS FILE DIRECTLY.
 // Edit the source file below and then run `npm run sync-files`
 // Source: ui/oopsyraidsy/data/03-hw/trial/thordan-ex.ts

ui/oopsyraidsy/data/06-ew/trial/zurvan-un.ts

@@ -1,4 +1,4 @@
-// This file was autogenerated from running ts-node util/sync_files.ts.
+// This file was autogenerated from running npm run sync-files.
 // DO NOT EDIT THIS FILE DIRECTLY.
 // Edit the source file below and then run `npm run sync-files`
 // Source: ui/oopsyraidsy/data/03-hw/trial/zurvan-ex.ts

ui/raidboss/data/06-ew/dungeon/another_mount_rokkon-savage.ts

@@ -1,4 +1,4 @@
-// This file was autogenerated from running ts-node util/sync_files.ts.
+// This file was autogenerated from running npm run sync-files.
 // DO NOT EDIT THIS FILE DIRECTLY.
 // Edit the source file below and then run `npm run sync-files`
 // Source: ui/raidboss/data/06-ew/dungeon/another_mount_rokkon.ts

ui/raidboss/data/06-ew/dungeon/another_mount_rokkon-savage.txt

@@ -1,4 +1,4 @@
-# This file was autogenerated from running ts-node util/sync_files.ts.
+# This file was autogenerated from running npm run sync-files.
 # DO NOT EDIT THIS FILE DIRECTLY.
 # Edit the source file below and then run `npm run sync-files`
 # Source: ui/raidboss/data/06-ew/dungeon/another_mount_rokkon.txt

ui/raidboss/data/06-ew/dungeon/another_sildihn_subterrane-savage.ts

@@ -1,4 +1,4 @@
-// This file was autogenerated from running ts-node util/sync_files.ts.
+// This file was autogenerated from running npm run sync-files.
 // DO NOT EDIT THIS FILE DIRECTLY.
 // Edit the source file below and then run `npm run sync-files`
 // Source: ui/raidboss/data/06-ew/dungeon/another_sildihn_subterrane.ts

ui/raidboss/data/06-ew/dungeon/another_sildihn_subterrane-savage.txt

@@ -1,4 +1,4 @@
-# This file was autogenerated from running ts-node util/sync_files.ts.
+# This file was autogenerated from running npm run sync-files.
 # DO NOT EDIT THIS FILE DIRECTLY.
 # Edit the source file below and then run `npm run sync-files`
 # Source: ui/raidboss/data/06-ew/dungeon/another_sildihn_subterrane.txt

ui/raidboss/data/06-ew/trial/sophia-un.ts

@@ -1,4 +1,4 @@
-// This file was autogenerated from running ts-node util/sync_files.ts.
+// This file was autogenerated from running npm run sync-files.
 // DO NOT EDIT THIS FILE DIRECTLY.
 // Edit the source file below and then run `npm run sync-files`
 // Source: ui/raidboss/data/03-hw/trial/sophia-ex.ts

ui/raidboss/data/06-ew/trial/sophia-un.txt

@@ -1,4 +1,4 @@
-# This file was autogenerated from running ts-node util/sync_files.ts.
+# This file was autogenerated from running npm run sync-files.
 # DO NOT EDIT THIS FILE DIRECTLY.
 # Edit the source file below and then run `npm run sync-files`
 # Source: ui/raidboss/data/03-hw/trial/sophia-ex.txt

ui/raidboss/data/06-ew/trial/thordan-un.ts

@@ -1,4 +1,4 @@
-// This file was autogenerated from running ts-node util/sync_files.ts.
+// This file was autogenerated from running npm run sync-files.
 // DO NOT EDIT THIS FILE DIRECTLY.
 // Edit the source file below and then run `npm run sync-files`
 // Source: ui/raidboss/data/03-hw/trial/thordan-ex.ts

ui/raidboss/data/06-ew/trial/thordan-un.txt

@@ -1,4 +1,4 @@
-# This file was autogenerated from running ts-node util/sync_files.ts.
+# This file was autogenerated from running npm run sync-files.
 # DO NOT EDIT THIS FILE DIRECTLY.
 # Edit the source file below and then run `npm run sync-files`
 # Source: ui/raidboss/data/03-hw/trial/thordan-ex.txt

ui/raidboss/data/06-ew/trial/zurvan-un.ts

@@ -1,4 +1,4 @@
-// This file was autogenerated from running ts-node util/sync_files.ts.
+// This file was autogenerated from running npm run sync-files.
 // DO NOT EDIT THIS FILE DIRECTLY.
 // Edit the source file below and then run `npm run sync-files`
 // Source: ui/raidboss/data/03-hw/trial/zurvan-ex.ts

ui/raidboss/data/06-ew/trial/zurvan-un.txt

@@ -1,4 +1,4 @@
-# This file was autogenerated from running ts-node util/sync_files.ts.
+# This file was autogenerated from running npm run sync-files.
 # DO NOT EDIT THIS FILE DIRECTLY.
 # Edit the source file below and then run `npm run sync-files`
 # Source: ui/raidboss/data/03-hw/trial/zurvan-ex.txt

util/csv_util.ts

@@ -1,5 +1,3 @@
-#!/usr/bin/env ts-node-script
-
 import { parseString } from '@fast-csv/parse';
 import fetch from 'node-fetch';
 

util/sync_files.ts

@@ -10,7 +10,7 @@ const __filename = url.fileURLToPath(new URL('.', import.meta.url));
 const __dirname = path.basename(__filename);
 const root = path.join(__dirname, '../');
 
-const scriptName = 'ts-node util/sync_files.ts';
+const scriptName = 'npm run sync-files';
 
 export type ReplaceDict = { [key: string]: string };