plugin: delete fishing code and overlay #5919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dalamud's GatherBuddy plugin (https://github.com/Ottermandias/GatherBuddy) is a much better fishing tracker than cactbot's fisher overlay. If you were using this, you should switch to that. I'm sorry about your fish data; you could possibly get it out of IndexedDB and into GatherBuddy import with a good bit of work but it's not something I can help with. The fishing code is very out of date, was never converted to TypeScript, and hasn't gotten any attention other than me. I mentioned that I was planning to remove it on discord and in release notes, and nobody spoke up complaining that it was being removed let alone spoke up saying they wanted to maintain it. Sorry! If this is something you want to maintain, please speak up. You could probably, at least until the bait memory signature changes (probably in Dawntrail, but maybe never) or until cactbot makes some breaking change to code that it's using, keep using the fisher overlay you have locally already indefinitely. It just won't get updates and will probably break at some point in the future.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2023
Dalamud's GatherBuddy plugin (https://github.com/Ottermandias/GatherBuddy) is a much better fishing tracker than cactbot's fisher overlay. If you were using this, you should switch to that. I'm sorry about your fish data; you could possibly get it out of IndexedDB and into GatherBuddy import with a good bit of work but it's not something I can help with. The fishing code is very out of date, was never converted to TypeScript, and hasn't gotten any attention other than me. I mentioned that I was planning to remove it on discord and in release notes, and nobody spoke up complaining that it was being removed let alone spoke up saying they wanted to maintain it. Sorry! If this is something you want to maintain, please speak up. You could probably, at least until the bait memory signature changes (probably in Dawntrail, but maybe never) or until cactbot makes some breaking change to code that it's using, keep using the fisher overlay you have locally already indefinitely. It just won't get updates and will probably break at some point in the future. 58fa46b
|
People do read these, and appreciate your work. <3 |
|
You told me to speak up so i speak up. Since im not using Dalamud i was using your fisher overlay for a long time. If it would be updated and maintained i would appreciate it and i will use it happily again:) If you dont have the time or energy to do it, i can understand it as well;) |
|
Your best bet is to start using dalamud and use GatherBuddy. Your next best alternative is to manually install an older cactbot version and use that (cancelling updates) until it stops working. If you want to maintain this yourself, I can give you a few pointers on how you might go about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dalamud's GatherBuddy plugin (https://github.com/Ottermandias/GatherBuddy) is a much better fishing tracker than cactbot's fisher overlay. If you were using this, you should switch to that.
I'm sorry about your fish data; you could possibly get it out of IndexedDB and into GatherBuddy import with a good bit of work but it's not something I can help with.
The fishing code is very out of date, was never converted to TypeScript, and hasn't gotten any attention other than me. I mentioned that I was planning to remove it on several discords (ffxiv act plugin, fishcord) and in release notes, and nobody spoke up complaining that it was being removed let alone spoke up saying they wanted to maintain it. Sorry!
If this is something you want to maintain, please speak up.
You could probably, at least until the bait memory signature changes (probably in Dawntrail, but maybe never) or until cactbot makes some breaking change to code that it's using, keep using the fisher overlay you have locally already indefinitely. It just won't get updates and will probably break at some point in the future.sorry for my own misunderstanding, it's no longer working now unless you revert to an older cactbot plugin manually