ci: do release based on version not tag #5953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows releases to be done via PR and not via git push. Notes: * .npmrc combines tag+commit logic and so if you turn off tagging the commit has to be done manually; this is now in bump_version.ts * this largely copies from OverlayPlugin's release.yml
|
I'll see how this goes and revert if I broke stuff. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
This allows releases to be done via PR and not via git push. Notes: * .npmrc combines tag+commit logic and so if you turn off tagging the commit has to be done manually; this is now in bump_version.ts * this largely copies from OverlayPlugin's release.yml 9a3a5cb
quisquous
added a commit
that referenced
this pull request
Nov 29, 2023
quisquous
added a commit
that referenced
this pull request
Nov 29, 2023
quisquous
added a commit
that referenced
this pull request
Nov 29, 2023
There's no reason to do another setup step here to get git for a one-liner. More fixes for #5953.
quisquous
added a commit
that referenced
this pull request
Nov 29, 2023
There's no reason to do another setup step here to get git for a one-liner. More fixes for #5953.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows releases to be done via PR and not via git push.
Notes: