refector: 重构ping以解决丢包数量错误的问题 #7
Merged
+143
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quqiOnfree
force-pushed
the
fix_ping
branch
2 times, most recently
from
b28c7a6 to
e5d0b4b
Compare
Owner
Author
|
为了方便Reivew，现把改前和改后的逻辑进行对比： 改前逻辑之前是顺序发送和读取，但是有的时候过了timeout时间依旧收到了包，这时就有两个包了，下一次接收的时候就是接收上一次的包，但是我没有写丢弃包的逻辑，就默认认为他这个包不对，直接返回了一个timeout，后面就顺延下来，后面的就全都丢了。 改后逻辑现在写的这个逻辑是递归读取，如果读取到的sequence值小于当前值，直接丢弃重新读取，直到到现在这个sequence。 希望对review有帮助！ |
Collaborator
|
感谢大佬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用的时候发现丢包数量远多于实际数量，需要重构
重构ping以解决丢包数量错误的问题
同时重构async_ping函数为模板类，拆分代码块，让代码更易读和维护