Merge pull request #20 from Wesmania/fix-quoted-filter-values

Don't explicitly quote filter values
qvantel · Jul 16, 2018 · 3d1a6fc · 3d1a6fc
2 parents c5e7156 + fd77fe4
commit 3d1a6fc
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 2 deletions.
diff --git a/src/jsonapi_client/filter.py b/src/jsonapi_client/filter.py
@@ -71,5 +71,5 @@ def format_filter_query(self, **kwargs: 'FilterKeywords') -> str:
         """
         def jsonify_key(key):
             return key.replace('__', '.').replace('_', '-')
-        return '&'.join(f'filter[{jsonify_key(key)}]="{value}"'
+        return '&'.join(f'filter[{jsonify_key(key)}]={value}'
                         for key, value in kwargs.items())
diff --git a/...json/external__filter[title]=__Hep__.json → tests/json/external__filter[title]=Hep.json b/...json/external__filter[title]=__Hep__.json → tests/json/external__filter[title]=Hep.json
diff --git a/...t_leases__filter[title]=__Dippadai__.json → .../test_leases__filter[title]=Dippadai.json b/...t_leases__filter[title]=__Dippadai__.json → .../test_leases__filter[title]=Dippadai.json
diff --git a/tests/test_client.py b/tests/test_client.py
@@ -865,7 +865,7 @@ def test_result_filtering(mocked_fetch, api_schema):
     s = Session('http://localhost:8080/', schema=api_schema)
 
     result = s.get('test_leases', Filter(title='Dippadai'))
-    result2 = s.get('test_leases', Filter(f'filter[title]="Dippadai"'))
+    result2 = s.get('test_leases', Filter(f'filter[title]=Dippadai'))
 
     assert result == result2