Skip to content

Commit

Permalink
feat(qwik-nx): bump deps
Browse files Browse the repository at this point in the history
  • Loading branch information
dmitry-stepanenko committed May 22, 2024
1 parent bb55d7a commit b2fbf4a
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 12 deletions.
17 changes: 17 additions & 0 deletions packages/qwik-nx/migrations.json
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,23 @@
"version": "^1.0.0"
}
}
},
"2.3.0": {
"version": "2.3.0",
"packages": {
"@builder.io/qwik": {
"version": "~1.5.5"
},
"@builder.io/qwik-city": {
"version": "~1.5.5"
},
"eslint-plugin-qwik": {
"version": "~1.5.5"
},
"vite": {
"version": "~5.2.0"
}
}
}
}
}
13 changes: 11 additions & 2 deletions packages/qwik-nx/src/utils/add-common-qwik-dependencies.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,22 @@ describe('init generator', () => {
expect(devDependencies['@builder.io/qwik']).toBe('my-version');
});

it('should override existing versions if they are listed in "unsupportedPackageVersions"', async () => {
it('should override existing versions if they are listed in "unsupportedPackageVersions" 1', async () => {
updateJson(appTree, 'package.json', (json) => {
(json.devDependencies ??= {})['vite'] = '5.1.1';
return json;
});
await addCommonQwikDependencies(appTree);
const { devDependencies } = readJson(appTree, 'package.json');
expect(devDependencies['vite']).toBe('~5.0.0');
expect(devDependencies['vite']).toBe('~5.2.0');
});
it('should not override existing versions if they are listed in "unsupportedPackageVersions" and have proper version', async () => {
updateJson(appTree, 'package.json', (json) => {
(json.devDependencies ??= {})['vite'] = '5.2.1';
return json;
});
await addCommonQwikDependencies(appTree);
const { devDependencies } = readJson(appTree, 'package.json');
expect(devDependencies['vite']).toBe('5.2.1');
});
});
2 changes: 1 addition & 1 deletion packages/qwik-nx/src/utils/add-common-qwik-dependencies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export function addCommonQwikDependencies(tree: Tree): GeneratorCallback {

const unsupportedPackageVersions = new Map<string, string>([
// https://github.com/vitejs/vite/issues/15870
['vite', '<5.1.0'],
['vite', '<5.1.0 || >=5.2.0'],
]);
let hasChanges = false;
for (const [dep, versionRange] of unsupportedPackageVersions.entries()) {
Expand Down
13 changes: 4 additions & 9 deletions packages/qwik-nx/src/utils/versions.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
// qwik packages
export const qwikVersion = '~1.4.4';
export const qwikCityVersion = '~1.4.4';
export const qwikEslintPluginVersion = '~1.4.4';
export const qwikVersion = '~1.5.5';
export const qwikCityVersion = '~1.5.5';
export const qwikEslintPluginVersion = '~1.5.5';

// css preprocessors
export const sassVersion = '~1.56.1';
export const lessVersion = '~4.1.3';
export const stylusVersion = '~0.59.0';

export const undiciVersion = '^5.22.0';
export const viteVersion = '~5.0.0';
export const viteVersion = '~5.2.0';
export const viteTsconfigPathsVersion = '~4.2.0';
export const vitestVersion = '^1.0.0';

Expand Down Expand Up @@ -45,11 +45,6 @@ export const vitePluginAngularVersion = '~0.2.0';
export const qwikAngularVersion = '~0.2.0';

// other
export const eslintVersion = '~8.36.0';
export const tsEslintVersion = '~5.43.0';
export const prettierVersion = '~2.8.7';
export const typescriptVersion = '~5.0.2';
export const nodeFetchVersion = '~3.3.0';
export const typesNodeVersion = '^18.16.1';
export const typesEslint = '~8.37.0';
export const tsMorphVersion = '^17.0.0';

0 comments on commit b2fbf4a

Please sign in to comment.