Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Extract GitHub link from submission #49

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Feature: Extract GitHub link from submission #49

merged 2 commits into from
Jul 12, 2023

Conversation

innerlize
Copy link
Contributor

@innerlize innerlize commented Jul 12, 2023 •
edited
Loading

Summary

Allows Robotina to only extract and save the GitHub link that students submit in classes after class 5.

Details

  • Create a helper to extract only the GitHub link from the submission.

Evidence

User submission



Robotina validates and saves the submission



TablePlus saved submission view

@innerlize
Create a link extractor for submissions
3365ede
@innerlize
Merge branch 'main' of https://github.com/r-argentina-programa/robotina…
4efc3f9 
… into feature/extract-github-link

# Conflicts:
#	src/utils/extractOnlySubmission.ts
@github-actions
Copy link

LCOV of commit 4efc3f9 during CI workflow #30

Summary coverage rate:
  lines......: 96.0% (624 of 650 lines)
  functions..: 98.2% (107 of 109 functions)
  branches...: 85.6% (155 of 181 branches)

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  src/utils/extractLinkFromSubmission.ts                                   |85.7%      7| 100%     1| 100%      1
  src/utils/extractOnlySubmission.ts                                       |90.0%     10| 100%     3| 100%      2

@innerlize innerlize merged commit 92e0b91 into main Jul 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@innerlize