Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dbWriteTable() correctly handles name clashes between temporary and permanent tables #431

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Apr 1, 2023

Closes #402.

@krlmlr krlmlr force-pushed the b-402-temp-table-name-clash branch from 1eba1b8 to a9bdd87 Compare July 8, 2023 04:20
@krlmlr krlmlr force-pushed the b-402-temp-table-name-clash branch from a9bdd87 to ca8b98f Compare November 8, 2023 10:47
Copy link
Contributor

aviator-app bot commented Nov 8, 2023

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Contributor

aviator-app bot commented Nov 8, 2023

This pull request failed to merge: some CI status(es) failed. Remove the blocked label to re-queue.

Failed CI(s): Smoke test: stock R

@krlmlr krlmlr force-pushed the b-402-temp-table-name-clash branch from ca8b98f to efb2cdf Compare April 1, 2024 09:51
@krlmlr krlmlr removed the blocked label Apr 1, 2024
@aviator-app aviator-app bot added the blocked label Apr 1, 2024
Copy link
Contributor

aviator-app bot commented Apr 1, 2024

This pull request failed to merge: some CI status(es) failed. Once the issues are resolved, remove the blocked label and re-queue the pull request. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Failed CI(s): Smoke test: stock R

@aviator-app aviator-app bot force-pushed the b-402-temp-table-name-clash branch from efb2cdf to 0f52039 Compare April 1, 2024 12:22
@krlmlr krlmlr force-pushed the b-402-temp-table-name-clash branch from 0f52039 to 637191c Compare April 1, 2024 13:45
@krlmlr krlmlr removed the blocked label Apr 1, 2024
@aviator-app aviator-app bot force-pushed the b-402-temp-table-name-clash branch from 637191c to beb732a Compare April 1, 2024 13:53
@aviator-app aviator-app bot merged commit d3a5569 into main Apr 1, 2024
17 checks passed
@aviator-app aviator-app bot deleted the b-402-temp-table-name-clash branch April 1, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbWriteTable(temporary = TRUE, overwrite = TRUE) deletes non-temporary table!
1 participant