AccessRight: 'open','embargoed', 'restricted','closed' #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add accessRight: 'open','embargoed', 'restricted','closed' for Zenodo
|
Documentation needs to be update ! |
|
I would be in favor to use an |
|
For the documentation of the metadata pivot metadata model it is through a CSV file that list possible keys and mark them if they are used in undelying actions: https://github.com/r-geoflow/geoflow/blob/master/doc/Summary_metadata.csv |
Change `embargoDate` in Rights to `embargo` in Date
|
Done ! Could you please review it |
eblondel
requested changes
Sep 6, 2023
There was a problem hiding this comment.
@kikislater the property for entity dates is dates, and not date
eblondel
approved these changes
Sep 6, 2023
eblondel
approved these changes
Sep 6, 2023
kikislater
commented
Sep 6, 2023
|
@kikislater can you implement a control with proper error log in case embargo date is missing (I assume it's a blocker in Zenodo if we don't specify this date) |
Add control to embargo date
eblondel
added a commit
that referenced
this pull request
Sep 6, 2023
Remove unexpected dash from previous PR #352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add accessRight and dependant (embargoDate, accessConditions) for Zenodo to geoflow
Tested with following drive shit: https://docs.google.com/spreadsheets/d/1wTyq-2sJgdvpTzE4309Lyo1vOac7uIb1dMeHEfKcqbg/edit?usp=sharing
and following json :
https://github.com/IRDG2OI/geoflow-g2oi/blob/sylvain/Zenodo.json
@juldebar