Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make optional test deps really optional #248

Merged
merged 5 commits into from
Mar 22, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Give up on R 3.6.x on Windows :(
Can't build an older version of magick, either.
gaborcsardi committed Mar 22, 2024
commit bc1a5bdc08d76b57e77d5c83d6ae41dacaaa1083
9 changes: 0 additions & 9 deletions .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
@@ -25,8 +25,6 @@ jobs:
- {os: macos-latest, r: 'release'}

- {os: windows-latest, r: 'release'}
# Use 3.6 to trigger usage of RTools35
- {os: windows-latest, r: '3.6'}
# use 4.1 to check with rtools40's older compiler
- {os: windows-latest, r: '4.1'}

@@ -54,13 +52,6 @@ jobs:
use-public-rspm: true

- uses: r-lib/actions/setup-r-dependencies@v2
if: ${{ startsWith(steps.setup-r.outputs.installed-r-version, '3') && runner.os == 'Windows' }}
with:
extra-packages: any::rcmdcheck, any::magick@2.8.2
needs: check

- uses: r-lib/actions/setup-r-dependencies@v2
if: ${{ ! startsWith(steps.setup-r.outputs.installed-r-version, '3') || runner.os != 'Windows' }}
with:
extra-packages: any::rcmdcheck
needs: check