Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make r_process and r_session not cloneable #289

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

karawoo
Copy link
Contributor

@karawoo karawoo commented Aug 15, 2024

Fixes #284

The dev version of R6 complains about a few other issues in callr -- would you like to make these finalize() methods private too? I can update the PR if so.

R6Class r_process: finalize() method is public, but it should be private as of R6 2.4.0. This code will continue to work, but in a future version of R6, finalize() will be required to be private.
R6Class r_session: finalize() method is public, but it should be private as of R6 2.4.0. This code will continue to work, but in a future version of R6, finalize() will be required to be private.
R6Class rcmd_process: finalize() method is public, but it should be private as of R6 2.4.0. This code will continue to work, but in a future version of R6, finalize() will be required to be private.
R6Class rscript_process: finalize() method is public, but it should be private as of R6 2.4.0. This code will continue to work, but in a future version of R6, finalize() will be required to be private.

@karawoo karawoo force-pushed the make-compatible-with-dev-R6 branch from 820ca45 to 78c0e9f Compare August 15, 2024 21:27
@gaborcsardi
Copy link
Member

Thank you!

@gaborcsardi gaborcsardi merged commit 6fd231d into r-lib:main Aug 28, 2024
13 checks passed
@gaborcsardi
Copy link
Member

would you like to make these finalize() methods private too? I can update the PR if so.

Thanks, I'll fix these in a sec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r_process subclass shouldn't be cloneable
2 participants