Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include {data.table} example in redundant_equals_linter() docs #2659

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

IndrajeetPatil
Copy link
Collaborator

closes #2657

@@ -30,6 +35,11 @@
#' linters = redundant_equals_linter()
#' )
#'
#' lint(
#' text = "dt[!(x), y]",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think a comment is warranted here...

IndrajeetPatil and others added 2 commits September 7, 2024 06:50
Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>
Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.95%. Comparing base (f0d9407) to head (308954c).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2659      +/-   ##
==========================================
- Coverage   97.96%   97.95%   -0.02%     
==========================================
  Files         126      126              
  Lines        5760     5766       +6     
==========================================
+ Hits         5643     5648       +5     
- Misses        117      118       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IndrajeetPatil IndrajeetPatil merged commit 927157a into main Sep 7, 2024
21 checks passed
@IndrajeetPatil IndrajeetPatil deleted the docs-redundant-equals-dt branch September 7, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include {data.table} example with and without lint for redundant_equals_linter() docs
2 participants