Test to check that all linters are covered by tags #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndrajeetPatil
commented
Sep 6, 2024
tests/testthat/test-linter_tags.R
Outdated
|
|
||
| test_that("all non-deprecated linters are covered across tags", { | ||
| tags <- setdiff(available_tags(), "deprecated") | ||
| tagged_linters <- lapply(tags, function(tag) names(linters_with_tags(tag))) # nolint: undesirable_function_linter. |
There was a problem hiding this comment.
The output length is going to be different across tags, so not sure how to use vapply() instead of lapply().
|
This test could work by just looking at the |
That's much cleaner! Thanks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2660 +/- ##
==========================================
- Coverage 97.96% 97.95% -0.02%
==========================================
Files 126 126
Lines 5760 5766 +6
==========================================
+ Hits 5643 5648 +5
- Misses 117 118 +1 ☔ View full report in Codecov by Sentry. |
AshesITR
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.