Skip packages that fail to download instead of stopping #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a package cannot be downloaded after 20 attempts (e.g., archived or unavailable packages), gracefully skip it and continue checking other packages instead of throwing a fatal error. The failed package is: - Marked as done with PREPERROR status in the database - Recorded for both 'old' and 'new' checks - Logged with an informative message This follows the same pattern used in deps_install_done() for handling dependency installation failures. Fixes r-lib#281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a package cannot be downloaded after 20 attempts (e.g., archived or unavailable packages), gracefully skip it and continue checking other packages instead of throwing a fatal error.
The failed package is:
This follows the same pattern used in deps_install_done() for handling dependency installation failures.
Fixes #281