Allow manual specification of the ZIP file structure

[gaborcsardi]

This is the same as #51, seemingly I cannot push commits to that branch.

Closes #50.

[AshesITR]

Travis complains about a codoc error. devtools::document() should fix it.

[AshesITR]

Hi, I gave this branch a spin, but devtools::check() fails me again :(
NB PR #51 passes devtools::check() so something (re?)introduced the windows bug.

-- R CMD check results ------------------------------------- zip 2.0.4.9000 ----
Duration: 51.1s

> running tests for arch 'i386' ...
  See below...

> running tests for arch 'x64' ...
  See below...

> checking for executable files ... WARNING
  Found the following executable file:
    tools/zip.exe
  Source packages should not contain undeclared executable files.
  See section 'Package structure' in the 'Writing R Extensions' manual.

> checking Rd \usage sections ... WARNING
  Documented arguments not in \usage in documentation object 'zip':
    'keep_path'
  
  Functions with \usage entries need to have the appropriate \alias
  entries, and all their arguments documented.
  The \usage entries must correspond to syntactically valid R code.
  See chapter 'Writing R documentation files' in the 'Writing R
  Extensions' manual.

> checking for non-standard things in the check directory ... NOTE
  Found the following files/directories:
    'examples_i386' 'examples_x64' 'tests_i386' 'tests_x64'
    'zip-Ex_i386.Rout' 'zip-Ex_x64.Rout'

-- Test failures ------------------------------------------ testthat (i386) ----

> library(testthat)
> library(zip)

Attaching package: 'zip'

The following objects are masked from 'package:utils':

    unzip, zip

> 
> test_check("zip")
-- 1. Failure: unzip_process (@test-unzip-process.R#11)  --------------------------------------------------------------------------------------------------------------------
p1$get_exit_status() not equal to 0.
1/1 mismatches
[1] 13 - 0 == 13

-- 2. Failure: unzip_process (@test-unzip-process.R#13)  --------------------------------------------------------------------------------------------------------------------
file.exists(file.path(tmp2, basename(z$ex), "file1")) isn't true.

-- 3. Failure: unzip_process (@test-unzip-process.R#14)  --------------------------------------------------------------------------------------------------------------------
file.exists(file.path(tmp2, basename(z$ex), "dir")) isn't true.

-- 4. Failure: unzip_process (@test-unzip-process.R#15)  --------------------------------------------------------------------------------------------------------------------
file.exists(file.path(tmp2, basename(z$ex), "dir", "file2")) isn't true.

-- 5. Error: unzip_process (@test-unzip-process.R#17)  ----------------------------------------------------------------------------------------------------------------------
cannot open the connection
Backtrace:
 1. testthat::expect_equal(...)
 4. base::readLines(file.path(tmp2, basename(z$ex), "file1"))
 5. base::file(con, "r")

== testthat results  ========================================================================================================================================================
[ OK: 192 | SKIPPED: 5 | WARNINGS: 1 | FAILED: 5 ]
1. Failure: unzip_process (@test-unzip-process.R#11) 
2. Failure: unzip_process (@test-unzip-process.R#13) 
3. Failure: unzip_process (@test-unzip-process.R#14) 
4. Failure: unzip_process (@test-unzip-process.R#15) 
5. Error: unzip_process (@test-unzip-process.R#17) 

Error: testthat unit tests failed
Execution halted

-- Test failures ------------------------------------------- testthat (x64) ----

> library(testthat)
> library(zip)

Attaching package: 'zip'

The following objects are masked from 'package:utils':

    unzip, zip

> 
> test_check("zip")
-- 1. Failure: unzip_process (@test-unzip-process.R#11)  --------------------------------------------------------------------------------------------------------------------
p1$get_exit_status() not equal to 0.
1/1 mismatches
[1] 13 - 0 == 13

-- 2. Failure: unzip_process (@test-unzip-process.R#13)  --------------------------------------------------------------------------------------------------------------------
file.exists(file.path(tmp2, basename(z$ex), "file1")) isn't true.

-- 3. Failure: unzip_process (@test-unzip-process.R#14)  --------------------------------------------------------------------------------------------------------------------
file.exists(file.path(tmp2, basename(z$ex), "dir")) isn't true.

-- 4. Failure: unzip_process (@test-unzip-process.R#15)  --------------------------------------------------------------------------------------------------------------------
file.exists(file.path(tmp2, basename(z$ex), "dir", "file2")) isn't true.

-- 5. Error: unzip_process (@test-unzip-process.R#17)  ----------------------------------------------------------------------------------------------------------------------
cannot open the connection
Backtrace:
 1. testthat::expect_equal(...)
 4. base::readLines(file.path(tmp2, basename(z$ex), "file1"))
 5. base::file(con, "r")

== testthat results  ========================================================================================================================================================
[ OK: 192 | SKIPPED: 5 | WARNINGS: 1 | FAILED: 5 ]
1. Failure: unzip_process (@test-unzip-process.R#11) 
2. Failure: unzip_process (@test-unzip-process.R#13) 
3. Failure: unzip_process (@test-unzip-process.R#14) 
4. Failure: unzip_process (@test-unzip-process.R#15) 
5. Error: unzip_process (@test-unzip-process.R#17) 

Error: testthat unit tests failed
Execution halted
Fehler: R CMD check found ERRORs

2 errors x | 2 warnings x | 1 note x

[gaborcsardi]

Unfortunately this is a rather big change to the existing code, and I'll have no time to review it before the coming release. :( Sorry about that. I'll get to it next time.