check URL on pull request only

NAMESPACE

@@ -1,6 +1,7 @@
 # Generated by roxygen2: do not edit by hand
 
 export(assert_package)
+export(assert_package_url)
 export(build_universe)
 export(review_pull_request)
 export(review_pull_requests)

R/assert_package.R

@@ -1,8 +1,8 @@
-#' @title Validate a package entry.
+#' @title Validate a Package Entry
 #' @export
 #' @keywords internal
 #' @description Validate a package entry.
-#' @return An character string if there is a problem with the package entry,
+#' @return A character string if there is a problem with the package entry,
 #'   otherwise `NULL` if there are no issues.
 assert_package <- function(path) {
   if (!is_character_scalar(path)) {
@@ -40,25 +40,34 @@ assert_package_contents <- function(name, url) {
       paste("Found malformed URL", shQuote(url), "of package", shQuote(name))
     )
   }
+}
+
+#' @title Validate a Package URL
+#' @export
+#' @keywords internal
+#' @description Validate that the package URL is in the description file if on
+#'   CRAN.
+#' @return A character string if there is a problem with the URL for the given
+#'   package name, otherwise `NULL` if there are no issues.
+assert_package_url <- function(name, url) {
+
   res <- ps(name, size = 1L)
   pkg <- res[["package"]]
   if (length(pkg) && name == pkg) {
-
     purl <- parse_url(sub("/$", "", url, perl = TRUE))
     urls <- strsplit(res[["url"]], ",\n|, |\n", perl = TRUE)[[1L]]
     for (u in urls) {
       pu <- parse_url(sub("/$", "", u, perl = TRUE))
       purl[["host"]] == pu[["host"]] && purl[["path"]] == pu[["path"]] &&
         return(invisible())
     }
-
     burl <- parse_url(res[["bugreports"]])
     purl[["host"]] == burl[["host"]] &&
       purl[["path"]] == sub("/issues/*$", "", burl[["path"]], perl = TRUE) &&
       return(invisible())
-
     return(
-      paste("URL of CRAN package", shQuote(name), "is not", shQuote(url))
+      paste("CRAN package", shQuote(name), "does not have URL", shQuote(url))
     )
   }
+
 }

R/review_pull_request.R

@@ -93,6 +93,22 @@ review_pull_request <- function(
       )
       return(invisible())
     }
+    result <- assert_package_url(name = name, url = url)
+    if (!is.null(result)) {
+      pull_request_defer(
+        owner = owner,
+        repo = repo,
+        number = number,
+        message = paste0(
+          "Pull request ",
+          number,
+          " automated diagnostics failed: ",
+          result,
+          ". Manual review required."
+        )
+      )
+      return(invisible())
+    }
   }
   pull_request_merge(
     owner = owner,

tests/test-assert_package.R

@@ -55,3 +55,59 @@ dir.create(dirname(path))
 writeLines("https://github.com/owner/package", path)
 stopifnot(is.null(r.releases.utils::assert_package(path = path)))
 unlink(dirname(path), recursive = TRUE)
+
+stopifnot(
+  grepl(
+    "does not have URL",
+    r.releases.utils::assert_package_url(
+      name = "gh",
+      url = "https://github.com/r-lib/gha"
+    ),
+    fixed = TRUE
+  )
+)
+
+stopifnot(
+  is.null(
+    r.releases.utils::assert_package_url(
+      name = "gh",
+      url = "https://github.com/r-lib/gh"
+    )
+  )
+)
+
+stopifnot(
+  is.null(
+    r.releases.utils::assert_package_url(
+      name = "curl",
+      url = "https://github.com/jeroen/curl/"
+    )
+  )
+)
+
+stopifnot(
+  is.null(
+    r.releases.utils::assert_package_url(
+      name = "curl",
+      url = "https://github.com/jeroen/curl/"
+    )
+  )
+)
+
+stopifnot(
+  is.null(
+    r.releases.utils::assert_package_url(
+      name = "jsonlite",
+      url = "https://github.com/jeroen/jsonlite"
+    )
+  )
+)
+
+stopifnot(
+  is.null(
+    r.releases.utils::assert_package_url(
+      name = "packageNOTonCRAN",
+      url = "https://github.com/jeroen/jsonlite"
+    )
+  )
+)