Fixes packages with no URL listed in description

r-multiverse · Mar 5, 2024 · d9be80f · d9be80f
1 parent 3cad892
commit d9be80f
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: r.releases.utils
 Title: Utilities for An R Universe of Package Releases
 Description: Utilities for an R universe of package releases.
-Version: 0.0.8
+Version: 0.0.8.9000
 License: MIT + file LICENSE
 URL:
   https://r-releases.github.io/r.releases.utils/,

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# r.releases.utils 0.0.8.9000 (development)
+
+* Makes `review_pull_requests()` robust to a package description with no URL listed.
+
 # r.releases.utils 0.0.8
 
 * Use R-releases and not `r-releases` to refer to the project.

diff --git a/R/assert_cran_url.R b/R/assert_cran_url.R
@@ -16,7 +16,13 @@ assert_cran_url <- function(name, url) {
     return(invisible())
   }
   package <- result[["Package"]]
-  main_urls <- strsplit(result[["URL"]], ",\n|, |\n", perl = TRUE)[[1L]]
+  main_urls <- unlist(
+    strsplit(
+      as.character(result[["URL"]]),
+      ",\n|, |\n",
+      perl = TRUE
+    )
+  )
   bugs_url <- sub(
     pattern = "/issues/*$",
     replacement = "",

diff --git a/tests/test-assert_package.R b/tests/test-assert_package.R
@@ -140,6 +140,17 @@ stopifnot(
   )
 )
 
+stopifnot(
+  grepl(
+    "does not appear in its DESCRIPTION file published on CRAN",
+    r.releases.utils::assert_cran_url(
+      name = "assertthat",
+      url = "https://github.com/hadley/assertthat"
+    ),
+    fixed = TRUE
+  )
+)
+
 stopifnot(
   grepl(
     "returned HTTP error",