Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: format in ci.yml #287

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

tsenovilla
Copy link
Contributor

The rustfmt.toml used in the repo contains a lot of features that are only available in nightly Rust.

Check this action for example to see all the produced warnings: https://github.com/r0gue-io/pop-cli/actions/runs/10475779407/job/29013207726

Running cargo fmt in nightly Rust during the CI enable those features, which produces a nicer Rust format

@tsenovilla tsenovilla changed the title Refactor of ci.yml Refactor: format in ci.yml Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 70.26%. Comparing base (1d41cd4) to head (71838be).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/new/pallet.rs 0.00% 5 Missing ⚠️
crates/pop-cli/src/commands/new/parachain.rs 0.00% 1 Missing and 1 partial ⚠️
crates/pop-cli/src/commands/install/mod.rs 0.00% 1 Missing ⚠️
crates/pop-cli/src/commands/up/parachain.rs 0.00% 1 Missing ⚠️
crates/pop-common/src/lib.rs 50.00% 0 Missing and 1 partial ⚠️
crates/pop-common/src/sourcing/binary.rs 83.33% 0 Missing and 1 partial ⚠️
crates/pop-common/src/sourcing/mod.rs 66.66% 1 Missing ⚠️
crates/pop-parachains/src/build.rs 50.00% 0 Missing and 1 partial ⚠️
crates/pop-parachains/src/up/mod.rs 50.00% 1 Missing ⚠️
@@           Coverage Diff           @@
##             main     #287   +/-   ##
=======================================
  Coverage   70.26%   70.26%           
=======================================
  Files          53       53           
  Lines        9086     9086           
  Branches     9086     9086           
=======================================
  Hits         6384     6384           
  Misses       1720     1720           
  Partials      982      982           
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/build/spec.rs 0.00% <ø> (ø)
crates/pop-cli/src/commands/up/contract.rs 25.65% <100.00%> (ø)
crates/pop-common/src/git.rs 75.99% <ø> (ø)
crates/pop-common/src/manifest.rs 93.22% <ø> (ø)
crates/pop-common/src/templates/extractor.rs 70.31% <100.00%> (ø)
crates/pop-parachains/src/utils/helpers.rs 79.77% <100.00%> (ø)
crates/pop-cli/src/commands/install/mod.rs 0.00% <0.00%> (ø)
crates/pop-cli/src/commands/up/parachain.rs 7.55% <0.00%> (ø)
crates/pop-common/src/lib.rs 63.63% <50.00%> (ø)
crates/pop-common/src/sourcing/binary.rs 92.30% <83.33%> (ø)
... and 5 more

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We change it in pop-node too just a week ago: r0gue-io/pop-node#184

@AlexD10S AlexD10S changed the title Refactor: format in ci.yml style: format in ci.yml Aug 29, 2024
@tsenovilla
Copy link
Contributor Author

Resolved conflicts with main branch. Should be ready to merge :)

@AlexD10S AlexD10S self-requested a review September 4, 2024 09:37
@AlexD10S AlexD10S merged commit f9ebdd3 into r0gue-io:main Sep 4, 2024
17 of 18 checks passed
@tsenovilla tsenovilla deleted the nightly-format-in-CI branch September 4, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants