-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pop bench pallet
logic implementation
#405
feat: pop bench pallet
logic implementation
#405
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #405 +/- ##
==========================================
- Coverage 75.11% 74.99% -0.13%
==========================================
Files 63 64 +1
Lines 13842 13905 +63
Branches 13842 13905 +63
==========================================
+ Hits 10398 10428 +30
- Misses 2118 2141 +23
- Partials 1326 1336 +10
|
pop bench pallet
logic implementation
@@ -23,6 +23,11 @@ mod wallet_integration; | |||
|
|||
#[tokio::main] | |||
async fn main() -> Result<()> { | |||
// Set environment for logging configuration, requires for `pop bench`. | |||
if std::env::var("RUST_LOG").is_err() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires to log the messages from frame-benchmarking-cli
"--runtime", | ||
runtime_wasm_path.to_str().unwrap(), | ||
"--pallet", | ||
"pallet_timestamp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Takes quite quick to benchmark pallet_timestamp
. This optimistically expects the test WASM binary is configured with pallet timestamp (common with most of Substrate runtimes)
Features
bench
to benchmark pallets & parachain.frame-benchmarking-cli
as a subcommand.How to test?
Use the below command in your pop-cli project to benchmark the
base_parachain.wasm
.Or run a command
pop bench pallet
To run benchmarking, builds the parachain runtime and specify the runtime path with
--runtime