Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: profile comment in build_parachain #406

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

chungquantin
Copy link
Collaborator

Minor fix for the parameter type of build_parachain

Minor fix for the parameter type of `build_parachain`
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.11%. Comparing base (2e03233) to head (3a8f086).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main     #406   +/-   ##
=======================================
  Coverage   75.11%   75.11%           
=======================================
  Files          63       63           
  Lines       13842    13842           
  Branches    13842    13842           
=======================================
  Hits        10398    10398           
  Misses       2118     2118           
  Partials     1326     1326           
Files with missing lines Coverage Δ
crates/pop-parachains/src/build.rs 88.17% <ø> (ø)

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@AlexD10S AlexD10S changed the title chore: profile comment in build_parachain docs: profile comment in build_parachain Feb 12, 2025
@AlexD10S AlexD10S merged commit 84e9d0b into main Feb 12, 2025
20 checks passed
@AlexD10S AlexD10S deleted the chungquantin/fix-build_parachain_comment branch February 12, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants