feat: api fungibles pallet #131
Triggered via pull request
July 21, 2024 13:01
Daanvdplas
Daanvdplas
synchronize
#113
Status
Success
Total duration
11s
Artifacts
–
lint-pr.yml
on: pull_request_target
Validate PR title for conventional commit compliance
3s
Annotations
1 error and 11 warnings
|
failed to resolve: use of undeclared crate or module `pop_primitives`:
runtime/testnet/src/extensions.rs#L9
error[E0433]: failed to resolve: use of undeclared crate or module `pop_primitives`
--> runtime/testnet/src/extensions.rs:9:5
|
9 | use pop_primitives::storage_keys::RuntimeStateKeys;
| ^^^^^^^^^^^^^^ use of undeclared crate or module `pop_primitives`
|
help: there is a crate or module with a similar name
|
9 | use primitives::storage_keys::RuntimeStateKeys;
| ~~~~~~~~~~
|
|
use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.:
runtime/testnet/src/lib.rs#L340
warning: use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.
--> runtime/testnet/src/lib.rs:340:57
|
340 | type OnChargeTransaction = pallet_transaction_payment::CurrencyAdapter<Balances, ()>;
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
bound is defined in more than one place:
runtime/testnet/src/extensions.rs#L33
warning: bound is defined in more than one place
--> runtime/testnet/src/extensions.rs:33:10
|
33 | fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
| ^
34 | where
35 | E: Ext<T = T>,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
= note: `#[warn(clippy::multiple_bound_locations)]` on by default
|
|
casting to the same type is unnecessary (`u8` -> `u8`):
runtime/devnet/src/lib.rs#L983
warning: casting to the same type is unnecessary (`u8` -> `u8`)
--> runtime/devnet/src/lib.rs:983:3
|
983 | Fungibles(fungibles::Keys<T>) = FUNGIBLES,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `FUNGIBLES`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
constant `V0` is never used:
runtime/devnet/src/extensions/mod.rs#L32
warning: constant `V0` is never used
--> runtime/devnet/src/extensions/mod.rs:32:7
|
32 | const V0: u8 = 0;
| ^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused import: `approvals::Inspect`:
runtime/devnet/src/extensions/mod.rs#L6
warning: unused import: `approvals::Inspect`
--> runtime/devnet/src/extensions/mod.rs:6:15
|
6 | fungibles::{approvals::Inspect as ApprovalInspect, metadata::Inspect as MetadataInspect},
| ^^^^^^^^^^^^^^^^^^
|
|
use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.:
runtime/devnet/src/lib.rs#L347
warning: use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.
--> runtime/devnet/src/lib.rs:347:57
|
347 | type OnChargeTransaction = pallet_transaction_payment::CurrencyAdapter<Balances, ()>;
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
bound is defined in more than one place:
runtime/devnet/src/extensions/mod.rs#L52
warning: bound is defined in more than one place
--> runtime/devnet/src/extensions/mod.rs:52:10
|
52 | fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
| ^
53 | where
54 | E: Ext<T = T>,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
= note: `#[warn(clippy::multiple_bound_locations)]` on by default
|
|
unused imports: `Balance`, `Runtime`, `UNIT`:
runtime/devnet/src/extensions/mod.rs#L24
warning: unused imports: `Balance`, `Runtime`, `UNIT`
--> runtime/devnet/src/extensions/mod.rs:24:30
|
24 | AccountId, AllowedApiCalls, Balance, Runtime, RuntimeCall, RuntimeOrigin, UNIT,
| ^^^^^^^ ^^^^^^^ ^^^^
|
|
unused import: `metadata::Inspect as MetadataInspect`:
runtime/devnet/src/extensions/mod.rs#L6
warning: unused import: `metadata::Inspect as MetadataInspect`
--> runtime/devnet/src/extensions/mod.rs:6:54
|
6 | fungibles::{approvals::Inspect as ApprovalInspect, metadata::Inspect as MetadataInspect},
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
used a field initializer for a tuple struct:
scripts/fund-dev-accounts/./main.rs#L54
warning: used a field initializer for a tuple struct
--> scripts/fund-dev-accounts/./main.rs:54:9
|
54 | id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `AssetId(Location { parents: 0, interior: Junctions::Here })`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
|
|
used a field initializer for a tuple struct:
scripts/fund-dev-accounts/./main.rs#L52
warning: used a field initializer for a tuple struct
--> scripts/fund-dev-accounts/./main.rs:52:36
|
52 | let assets = VersionedAssets::V4(Assets {
| __________________________________________^
53 | | 0: vec![Asset {
54 | | id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
55 | | fun: amount,
56 | | }],
57 | | });
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
= note: `#[warn(clippy::init_numbered_fields)]` on by default
help: try
|
52 ~ let assets = VersionedAssets::V4(Assets(<[_]>::into_vec(
53 + // This rustc_box is not required, but it produces a dramatic improvement in compile
54 + // time when constructing arrays with many elements.
55 + #[rustc_box]
56 + $crate::boxed::Box::new([$($x),+])
57 ~ )));
|
|