Skip to content

feat: pop api crate #11

feat: pop api crate

feat: pop api crate #11

Triggered via pull request March 2, 2024 02:13
Status Failure
Total duration 39m 13s
Artifacts

build.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 14 warnings
test
Process completed with exit code 101.
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
this function has too many arguments (14/7): node/src/service.rs#L368
warning: this function has too many arguments (14/7) --> node/src/service.rs:368:1 | 368 | / fn start_consensus( 369 | | client: Arc<ParachainClient>, 370 | | block_import: ParachainBlockImport, 371 | | prometheus_registry: Option<&Registry>, ... | 382 | | announce_block: Arc<dyn Fn(Hash, Option<Vec<u8>>) + Send + Sync>, 383 | | ) -> Result<(), sc_service::Error> { | |__________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
large size difference between variants: node/src/cli.rs#L5
warning: large size difference between variants --> node/src/cli.rs:5:1 | 5 | / pub enum Subcommand { 6 | | /// Build a chain specification. 7 | | BuildSpec(sc_cli::BuildSpecCmd), 8 | | ... | 19 | | ImportBlocks(sc_cli::ImportBlocksCmd), | | ------------------------------------- the second-largest variant contains at least 240 bytes ... | 39 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd), | | ----------------------------------------------- the largest variant contains at least 512 bytes ... | 48 | | Key(sc_cli::KeySubcommand), 49 | | } | |_^ the entire enum is at least 512 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 39 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
function `convert_err` is never used: runtime/src/extensions/pop_api_extension.rs#L19
warning: function `convert_err` is never used --> runtime/src/extensions/pop_api_extension.rs:19:4 | 19 | fn convert_err(err_msg: &'static str) -> impl FnOnce(DispatchError) -> DispatchError { | ^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
this is a decimal constant: runtime/src/lib.rs#L191
warning: this is a decimal constant --> runtime/src/lib.rs:191:19 | 191 | spec_version: 00_01_00, | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal = note: `#[warn(clippy::zero_prefixed_literal)]` on by default help: if you mean to use a decimal constant, remove the `0` to avoid confusion | 191 | spec_version: 1_00, | ~~~~ help: if you mean to use an octal constant, use `0o` | 191 | spec_version: 0o1_00, | ~~~~~~
multiple variants are never constructed: pop-api/src/v0/nfts.rs#L28
warning: multiple variants are never constructed --> pop-api/src/v0/nfts.rs:28:5 | 21 | pub(crate) enum NftCalls { | -------- variants in this enum ... 28 | Destroy { collection: CollectionId }, | ^^^^^^^ ... 37 | Burn { | ^^^^ ... 42 | Transfer { | ^^^^^^^^ ... 48 | Redeposit { | ^^^^^^^^^ ... 53 | LockItemTransfer { | ^^^^^^^^^^^^^^^^ ... 58 | UnlockItemTransfer { | ^^^^^^^^^^^^^^^^^^ ... 68 | TransferOwnership { | ^^^^^^^^^^^^^^^^^ ... 73 | SetTeam { | ^^^^^^^ ... 80 | ApproveTransfer { | ^^^^^^^^^^^^^^^ ... 87 | CancelApproval { | ^^^^^^^^^^^^^^ ... 93 | ClearAllTransferApprovals { | ^^^^^^^^^^^^^^^^^^^^^^^^^ ... 98 | LockItemProperties { | ^^^^^^^^^^^^^^^^^^ ... 120 | ApproveItemAttribute { | ^^^^^^^^^^^^^^^^^^^^ ... 126 | CancelItemAttributesApproval { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... 132 | SetMetadata { | ^^^^^^^^^^^ ... 138 | ClearMetadata { | ^^^^^^^^^^^^^ ... 143 | SetCollectionMetadata { | ^^^^^^^^^^^^^^^^^^^^^ ... 148 | ClearCollectionMetadata { collection: CollectionId }, | ^^^^^^^^^^^^^^^^^^^^^^^ 149 | #[codec(index = 28)] 150 | SetAcceptOwnership { | ^^^^^^^^^^^^^^^^^^ ... 155 | SetCollectionMaxSupply { | ^^^^^^^^^^^^^^^^^^^^^^ ... 165 | Price { | ^^^^^ ... 171 | BuyItem { | ^^^^^^^ ... 190 | CancelSwap { | ^^^^^^^^^^ ... 195 | ClaimSwap { | ^^^^^^^^^
type alias `MaxTips` is never used: pop-api/src/lib.rs#L23
warning: type alias `MaxTips` is never used --> pop-api/src/lib.rs:23:6 | 23 | type MaxTips = u32; | ^^^^^^^
type alias `KeyLimit` is never used: pop-api/src/lib.rs#L22
warning: type alias `KeyLimit` is never used --> pop-api/src/lib.rs:22:6 | 22 | type KeyLimit = u32; | ^^^^^^^^
type alias `Signature` is never used: pop-api/src/lib.rs#L20
warning: type alias `Signature` is never used --> pop-api/src/lib.rs:20:6 | 20 | type Signature = MultiSignature; | ^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
this import is redundant: pop-api/src/lib.rs#L6
warning: this import is redundant --> pop-api/src/lib.rs:6:1 | 6 | use scale; | ^^^^^^^^^^ help: remove it entirely | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports = note: `#[warn(clippy::single_component_path_imports)]` on by default
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, Swatinem/rust-cache@v2.5.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.