Skip to content

feat(pop-api): further implementation of nfts api #28

feat(pop-api): further implementation of nfts api

feat(pop-api): further implementation of nfts api #28

Triggered via pull request March 6, 2024 14:38
Status Success
Total duration 19m 47s
Artifacts

build.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
this function has too many arguments (14/7): node/src/service.rs#L358
warning: this function has too many arguments (14/7) --> node/src/service.rs:358:1 | 358 | / fn start_consensus( 359 | | client: Arc<ParachainClient>, 360 | | block_import: ParachainBlockImport, 361 | | prometheus_registry: Option<&Registry>, ... | 372 | | announce_block: Arc<dyn Fn(Hash, Option<Vec<u8>>) + Send + Sync>, 373 | | ) -> Result<(), sc_service::Error> { | |__________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
large size difference between variants: node/src/cli.rs#L5
warning: large size difference between variants --> node/src/cli.rs:5:1 | 5 | / pub enum Subcommand { 6 | | /// Build a chain specification. 7 | | BuildSpec(sc_cli::BuildSpecCmd), 8 | | ... | 19 | | ImportBlocks(sc_cli::ImportBlocksCmd), | | ------------------------------------- the second-largest variant contains at least 240 bytes ... | 39 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd), | | ----------------------------------------------- the largest variant contains at least 512 bytes ... | 48 | | Key(sc_cli::KeySubcommand), 49 | | } | |_^ the entire enum is at least 512 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 39 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
this is a decimal constant: runtime/src/lib.rs#L191
warning: this is a decimal constant --> runtime/src/lib.rs:191:16 | 191 | spec_version: 00_01_00, | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal = note: `#[warn(clippy::zero_prefixed_literal)]` on by default help: if you mean to use a decimal constant, remove the `0` to avoid confusion | 191 | spec_version: 1_00, | ~~~~ help: if you mean to use an octal constant, use `0o` | 191 | spec_version: 0o1_00, | ~~~~~~
this import is redundant: runtime/src/extensions.rs#L6
warning: this import is redundant --> runtime/src/extensions.rs:6:1 | 6 | use log; | ^^^^^^^^ help: remove it entirely | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports = note: `#[warn(clippy::single_component_path_imports)]` on by default
variants `Send` and `Receive` are never constructed: pop-api/src/v0/nfts.rs#L708
warning: variants `Send` and `Receive` are never constructed --> pop-api/src/v0/nfts.rs:708:3 | 706 | pub enum PriceDirection { | -------------- variants in this enum 707 | /// Tokens will be sent. 708 | Send, | ^^^^ 709 | /// Tokens will be received. 710 | Receive, | ^^^^^^^ | = note: `#[warn(dead_code)]` on by default
this import is redundant: pop-api/src/lib.rs#L9
warning: this import is redundant --> pop-api/src/lib.rs:9:1 | 9 | use scale; | ^^^^^^^^^^ help: remove it entirely | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports = note: `#[warn(clippy::single_component_path_imports)]` on by default
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, Swatinem/rust-cache@v2.5.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.