test: create an NFT collection #58
Triggered via pull request
April 26, 2024 08:11
brunopgalvao
brunopgalvao
synchronize
#82
Status
Success
Total duration
15s
Artifacts
–
lint-pr.yml
on: pull_request_target
Validate PR title for conventional commit compliance
5s
Annotations
3 warnings
|
used a field initializer for a tuple struct:
scripts/fund-dev-accounts/./main.rs#L54
warning: used a field initializer for a tuple struct
--> scripts/fund-dev-accounts/./main.rs:54:9
|
54 | id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `AssetId(Location { parents: 0, interior: Junctions::Here })`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
|
|
used a field initializer for a tuple struct:
scripts/fund-dev-accounts/./main.rs#L52
warning: used a field initializer for a tuple struct
--> scripts/fund-dev-accounts/./main.rs:52:36
|
52 | let assets = VersionedAssets::V4(Assets {
| __________________________________________^
53 | | 0: vec![Asset {
54 | | id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
55 | | fun: amount,
56 | | }],
57 | | });
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
= note: `#[warn(clippy::init_numbered_fields)]` on by default
help: try
|
52 ~ let assets = VersionedAssets::V4(Assets(<[_]>::into_vec(
53 + // This rustc_box is not required, but it produces a dramatic improvement in compile
54 + // time when constructing arrays with many elements.
55 + #[rustc_box]
56 + $crate::boxed::Box::new([$($x),+])
57 ~ )));
|
|
|
large size difference between variants:
node/src/cli.rs#L5
warning: large size difference between variants
--> node/src/cli.rs:5:1
|
5 | / pub enum Subcommand {
6 | | /// Build a chain specification.
7 | | BuildSpec(sc_cli::BuildSpecCmd),
8 | |
... |
19 | | ImportBlocks(sc_cli::ImportBlocksCmd),
| | ------------------------------------- the second-largest variant contains at least 240 bytes
... |
39 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd),
| | ----------------------------------------------- the largest variant contains at least 512 bytes
... |
48 | | Key(sc_cli::KeySubcommand),
49 | | }
| |_^ the entire enum is at least 512 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
39 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|