refactor: remove rococo #95
Triggered via pull request
June 22, 2024 14:52
evilrobot-01
synchronize
#89
Status
Success
Total duration
10s
Artifacts
–
lint-pr.yml
on: pull_request_target
Validate PR title for conventional commit compliance
2s
Annotations
4 warnings
used a field initializer for a tuple struct:
scripts/fund-dev-accounts/./main.rs#L54
warning: used a field initializer for a tuple struct
--> scripts/fund-dev-accounts/./main.rs:54:36
|
54 | let assets = VersionedAssets::V3(Assets {
| __________________________________________^
55 | | 0: vec![Asset {
56 | | id: Concrete(Location { parents: 0, interior: Junctions::Here }),
57 | | fun: amount,
58 | | }],
59 | | });
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
= note: `#[warn(clippy::init_numbered_fields)]` on by default
help: try
|
54 ~ let assets = VersionedAssets::V3(Assets(<[_]>::into_vec(
55 + // This rustc_box is not required, but it produces a dramatic improvement in compile
56 + // time when constructing arrays with many elements.
57 + #[rustc_box]
58 + $crate::boxed::Box::new([$($x),+])
59 ~ )));
|
|
large size difference between variants:
node/src/cli.rs#L5
warning: large size difference between variants
--> node/src/cli.rs:5:1
|
5 | / pub enum Subcommand {
6 | | /// Build a chain specification.
7 | | BuildSpec(sc_cli::BuildSpecCmd),
... |
19 | | ImportBlocks(sc_cli::ImportBlocksCmd),
| | ------------------------------------- the second-largest variant contains at least 240 bytes
... |
39 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd),
| | ----------------------------------------------- the largest variant contains at least 512 bytes
... |
48 | | Key(sc_cli::KeySubcommand),
49 | | }
| |_^ the entire enum is at least 512 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
39 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
bound is defined in more than one place:
runtime/testnet/src/extensions.rs#L44
warning: bound is defined in more than one place
--> runtime/testnet/src/extensions.rs:44:10
|
44 | fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
| ^
45 | where
46 | E: Ext<T = T>,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
= note: `#[warn(clippy::multiple_bound_locations)]` on by default
|
bound is defined in more than one place:
runtime/devnet/src/extensions.rs#L49
warning: bound is defined in more than one place
--> runtime/devnet/src/extensions.rs:49:10
|
49 | fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
| ^
50 | where
51 | E: Ext<T = T>,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
= note: `#[warn(clippy::multiple_bound_locations)]` on by default
|