feat: pallet assets pop api integration #106
Triggered via pull request
July 4, 2024 17:48
Daanvdplas
Daanvdplas
synchronize
#71
Status
Success
Total duration
10s
Artifacts
–
lint-pr.yml
on: pull_request_target
Validate PR title for conventional commit compliance
2s
Annotations
1 error and 11 warnings
|
non-exhaustive patterns: `pop_primitives::storage_keys::RuntimeStateKeys::Assets(_)` not covered:
runtime/testnet/src/extensions.rs#L204
error[E0004]: non-exhaustive patterns: `pop_primitives::storage_keys::RuntimeStateKeys::Assets(_)` not covered
--> runtime/testnet/src/extensions.rs:204:21
|
204 | let result = match key {
| ^^^ pattern `pop_primitives::storage_keys::RuntimeStateKeys::Assets(_)` not covered
|
note: `pop_primitives::storage_keys::RuntimeStateKeys` defined here
--> /home/runner/work/pop-node/pop-node/primitives/src/storage_keys.rs:6:1
|
6 | pub enum RuntimeStateKeys {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
...
15 | Assets(AssetsKeys),
| ------ not covered
= note: the matched value is of type `pop_primitives::storage_keys::RuntimeStateKeys`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
|
208 ~ },
209 ~ pop_primitives::storage_keys::RuntimeStateKeys::Assets(_) => todo!(),
|
|
|
used a field initializer for a tuple struct:
scripts/fund-dev-accounts/./main.rs#L54
warning: used a field initializer for a tuple struct
--> scripts/fund-dev-accounts/./main.rs:54:9
|
54 | id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `AssetId(Location { parents: 0, interior: Junctions::Here })`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
|
|
used a field initializer for a tuple struct:
scripts/fund-dev-accounts/./main.rs#L52
warning: used a field initializer for a tuple struct
--> scripts/fund-dev-accounts/./main.rs:52:36
|
52 | let assets = VersionedAssets::V4(Assets {
| __________________________________________^
53 | | 0: vec![Asset {
54 | | id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
55 | | fun: amount,
56 | | }],
57 | | });
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
= note: `#[warn(clippy::init_numbered_fields)]` on by default
help: try
|
52 ~ let assets = VersionedAssets::V4(Assets(<[_]>::into_vec(
53 + // This rustc_box is not required, but it produces a dramatic improvement in compile
54 + // time when constructing arrays with many elements.
55 + #[rustc_box]
56 + $crate::boxed::Box::new([$($x),+])
57 ~ )));
|
|
|
use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.:
runtime/devnet/src/lib.rs#L409
warning: use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.
--> runtime/devnet/src/lib.rs:409:57
|
409 | type OnChargeTransaction = pallet_transaction_payment::CurrencyAdapter<Balances, ()>;
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.:
runtime/testnet/src/lib.rs#L377
warning: use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.
--> runtime/testnet/src/lib.rs:377:57
|
377 | type OnChargeTransaction = pallet_transaction_payment::CurrencyAdapter<Balances, ()>;
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
bound is defined in more than one place:
runtime/devnet/src/extensions/mod.rs#L66
warning: bound is defined in more than one place
--> runtime/devnet/src/extensions/mod.rs:66:10
|
66 | fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
| ^
67 | where
68 | E: Ext<T = T>,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
= note: `#[warn(clippy::multiple_bound_locations)]` on by default
|
|
bound is defined in more than one place:
runtime/testnet/src/extensions.rs#L44
warning: bound is defined in more than one place
--> runtime/testnet/src/extensions.rs:44:10
|
44 | fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
| ^
45 | where
46 | E: Ext<T = T>,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
= note: `#[warn(clippy::multiple_bound_locations)]` on by default
|
|
casting integer literal to `u8` is unnecessary:
primitives/src/lib.rs#L68
warning: casting integer literal to `u8` is unnecessary
--> primitives/src/lib.rs:68:4
|
68 | / /// The number of transactional layers has been reached, or we are not in a transactional
69 | | /// layer.
70 | | Transactional(TransactionalError) = 9,
| |_________________________________________________^ help: try: `9_u8`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting integer literal to `u8` is unnecessary:
primitives/src/lib.rs#L66
warning: casting integer literal to `u8` is unnecessary
--> primitives/src/lib.rs:66:4
|
66 | / /// An arithmetic error.
67 | | Arithmetic(ArithmeticError) = 8,
| |___________________________________________^ help: try: `8_u8`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting integer literal to `u8` is unnecessary:
primitives/src/lib.rs#L64
warning: casting integer literal to `u8` is unnecessary
--> primitives/src/lib.rs:64:4
|
64 | / /// An error to do with tokens.
65 | | Token(TokenError) = 7,
| |_________________________________^ help: try: `7_u8`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting integer literal to `u8` is unnecessary:
primitives/src/lib.rs#L56
warning: casting integer literal to `u8` is unnecessary
--> primitives/src/lib.rs:56:4
|
56 | / /// A custom error in a module.
57 | | Module { index: u8, error: u8 } = 3,
| |_______________________________________________^ help: try: `3_u8`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting integer literal to `u8` is unnecessary:
primitives/src/lib.rs#L43
warning: casting integer literal to `u8` is unnecessary
--> primitives/src/lib.rs:43:4
|
43 | / /// Some unknown error occurred. Go to the Pop API docs section `Pop API error`.
44 | | Other {
45 | | // Index within the `DispatchError`
46 | | dispatch_error_index: u8,
... |
50 | | error: u8,
51 | | } = 0,
| |_________________^ help: try: `0_u8`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|