Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make drink generic to support pop-api #251

Open
3 of 4 tasks
Daanvdplas opened this issue Aug 30, 2024 · 1 comment
Open
3 of 4 tasks

feat: make drink generic to support pop-api #251

Daanvdplas opened this issue Aug 30, 2024 · 1 comment
Assignees

Comments

@Daanvdplas
Copy link
Collaborator

Daanvdplas commented Aug 30, 2024

We want to offer the developers a test suite for interacting with the pop chain extension. Luckily there is drink!.

Goal

Create an example contract (preferably with some logic around the api to see how what the devex is like - e.g. Error) using drink! for testing.

Steps

  • Fork the drink! repository with the following changes to make drink! mostly generic.
  • Move the required code from ink sandbox (e.g. the Sandbox trait) to the forked drink repository. This is not dependent of any ink code, see Cargo.toml`, so this should be straightforward. There are some useful macros that can be used as well.
  • Now in the pop-node repo we want to create a PopSandbox (here you can see how) which the developers can then use for their drink tests. One thing that I haven't tested yet is including the chain extension. The code says it handles it and there is also an example in the drink repository, so this should be doable.
  • When this all works we want to implement the example contract. This contract will be a very important exercise. Not only will we test the api, the error handling, the test suite, exposure to ink!, but also will be used for the first resource (most probably tutorial) for the pop api.
@chungquantin chungquantin self-assigned this Sep 1, 2024
@chungquantin
Copy link
Collaborator

Created a new private repository (will be converted to public later) for pop-drink: https://github.com/r0gue-io/pop-drink

@peterwht peterwht changed the title chore: drink feat: make drink generic to support pop-api Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants