chore(devnet): make drink generic over runtime #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## daan/api #255 +/- ##
===========================================
Coverage ? 34.10%
===========================================
Files ? 34
Lines ? 3011
Branches ? 3011
===========================================
Hits ? 1027
Misses ? 1952
Partials ? 32 |
Closed
6 tasks
|
Closed to rebase to v1.14.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue: #251
Note
Design consideration: Successfully create a
PopSandboxlocated under the folderpop-sandbox(Considered refactoring in the future for a reasonable structure).Caution
Why do we need a separate
pop-sandboxinstead of usingcreate_sandbox!macro to construct the runtime and sandbox for it? The approach was implemented before but got an issue with the HostFunction cumulus-primitives-proof-size-hostfunction when replacing the customizedSandboxin the drink test.Left a few TODOs about the current issues.
fix) A contract that usePop APIwill throwDeploymentRevertedorContractTrapped. This perhaps can be an issue with the chain extension.chore) Next task would be rebasing the branch todaan/api(1.14.0) and upgrade thepop-drinkrepository to 1.14.0 as well.