refactor: remove old api code #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daanvdplas
force-pushed
the
daan/refactor-remove_old_api_code
branch
from
63d3155
to
6c9a740
Compare
peterwht
reviewed
Jul 19, 2024
|
As Peter and I discussed, we are ignoring those clippy warnings for now because they will be introduced back in with the pop api PR. Please say when disagreeing |
evilrobot-01
approved these changes
Jul 19, 2024
peterwht
approved these changes
Jul 20, 2024
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only removes old code in the runtime so that it can no longer be used on testnet until API complete. Removing the code in other crates will be done on the
apibranch as soon as it is rebased on this PR because it is very different and feels like I would have to do the job twice.