feat: implement transfer_from and decrease_allowance
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chungquantin
changed the title
transfer_from and decrease_allowancetransfer_from and decrease_allowance
chungquantin
commented
Jul 23, 2024
|
Could you please use the old formatting |
…transfer-decrease
Daanvdplas
force-pushed
the
daan/feat-api_fungibles_pallet
branch
from
9d2276c
to
a8c4bb5
Compare
Daanvdplas
reviewed
Jul 23, 2024
| @@ -367,6 +403,69 @@ fn transfer_works() { | |||
| }); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn transfer_from_works() { | |||
There was a problem hiding this comment.
Could we add test situations for AssetNotLive. See other tests how to (freeze and destroy)
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
…transfer-decrease
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
|
This should be waited for review until #113 is approved |
…transfer-decrease
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent PR: #113
ISSUE: #104
Original wasm size: 30.7K, Optimized: 7.2K
Tasks
transfer_frompallet-apiimplementationdecrease_allowancepallet-apiimplementation