Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(testnet): bump version #144

Merged
merged 1 commit into from
Jul 29, 2024
Merged

build(testnet): bump version #144

merged 1 commit into from
Jul 29, 2024

Conversation

evilrobot-01
Copy link
Collaborator

Bumps runtime version ahead of next release, purely to resolve a node syncing issue introduced with the last version bump of dependencies (i.e. 1.7 SDK update via psvm -v 1.7.0).

The executor used is still the below, so the native wasm now built is panicing when verifying state roots, presumably due to the changes introduced in sp_api.

type ParachainExecutor<E> = NativeElseWasmExecutor<E>;

This version bump would have had to have happend in any case, but doing so ensures that the onchain wasm is used and the node syncs.

Further investigation and testing should be carried out.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.30%. Comparing base (e403ef4) to head (3d22c72).

@@          Coverage Diff          @@
##            main    #144   +/-   ##
=====================================
  Coverage   3.30%   3.30%           
=====================================
  Files         30      30           
  Lines       6843    6843           
  Branches    6843    6843           
=====================================
  Hits         226     226           
  Misses      6617    6617           
Files Coverage Δ
runtime/testnet/src/lib.rs 14.88% <ø> (ø)

Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for figuring this out!

@Daanvdplas Daanvdplas merged commit 95bb4b5 into main Jul 29, 2024
8 checks passed
@Daanvdplas Daanvdplas deleted the frank/bump-version branch July 29, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants