Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: asset management #149

Closed
wants to merge 40 commits into from
Closed

Conversation

Daanvdplas
Copy link
Collaborator

@Daanvdplas Daanvdplas commented Jul 30, 2024

Implements the functionality for asset management:

  • create
  • start_destroy
  • set_metadata
  • clear_metadata
  • contract example with creating an asset in the constructor or linking the contract to an existing asset.

The dispatchables required to completely destroy an asset:

  • destroy_accounts
  • destroy_approvals
  • finish_destroy
    , have not been included in the api because they do not have to be signed by the owner of the asset. In addition, it requires configurations of RemoveItemsLimit (originally from pallet assets) for the api::fungibles pallet to specify the max. # of accounts and approvals that can be removed in a single tx by a contract. This is all not needed if asset owners (in this case via a contract) are required to complete the steps of destroying an asset directly via the pallet (this is normally also the case). Only starting the destroying process of an asset has to be initiated by the contract if it is the owner of the asset.

Closes #92

@Daanvdplas Daanvdplas changed the title Daan/feat asset management feat: asset management Jul 30, 2024
@Daanvdplas Daanvdplas linked an issue Jul 30, 2024 that may be closed by this pull request
@Daanvdplas Daanvdplas closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat (pop api): implement asset management interfaces local fungibles
2 participants