feat: api events

pallets/api/src/fungibles/mod.rs

@@ -121,6 +121,15 @@ pub mod pallet {
 			/// Amount of tokens transferred (or minted/burned).
 			value: BalanceOf<T>,
 		},
+		/// Event emitted when a token class is created.
+		Create {
+			/// The ID of the asset.
+			id: AssetIdOf<T>,
+			/// Creator of the asset.
+			creator: AccountIdOf<T>,
+			/// Admin of the asset.
+			admin: AccountIdOf<T>,
+		},
 	}
 
 	#[pallet::call]
@@ -197,7 +206,7 @@ pub mod pallet {
 				.map_err(|e| e.with_weight(Self::weight_approve(0, 0)))?;
 			let current_allowance = AssetsOf::<T>::allowance(id.clone(), &owner, &spender);
 
-			let return_weight = match value.cmp(&current_allowance) {
+			let weight = match value.cmp(&current_allowance) {
 				// If the new value is equal to the current allowance, do nothing.
 				Equal => Self::weight_approve(0, 0),
 				// If the new value is greater than the current allowance, approve the difference
@@ -232,7 +241,7 @@ pub mod pallet {
 				},
 			};
 			Self::deposit_event(Event::Approval { id, owner, spender, value });
-			Ok(Some(return_weight).into())
+			Ok(Some(weight).into())
 		}
 
 		/// Increases the allowance of a spender.
@@ -279,13 +288,13 @@ pub mod pallet {
 		) -> DispatchResultWithPostInfo {
 			let owner = ensure_signed(origin.clone())
 				.map_err(|e| e.with_weight(Self::weight_approve(0, 0)))?;
+			if value.is_zero() {
+				return Ok(Some(Self::weight_approve(0, 0)).into());
+			}
 			let current_allowance = AssetsOf::<T>::allowance(id.clone(), &owner, &spender);
 			let spender_source = T::Lookup::unlookup(spender.clone());
 			let id_param: AssetIdParameterOf<T> = id.clone().into();
 
-			if value.is_zero() {
-				return Ok(Some(Self::weight_approve(0, 0)).into());
-			}
 			// Cancel the approval and set the new value if `new_allowance` is more than zero.
 			AssetsOf::<T>::cancel_approval(
 				origin.clone(),
@@ -318,7 +327,15 @@ pub mod pallet {
 			admin: AccountIdOf<T>,
 			min_balance: BalanceOf<T>,
 		) -> DispatchResult {
-			AssetsOf::<T>::create(origin, id.into(), T::Lookup::unlookup(admin), min_balance)
+			AssetsOf::<T>::create(
+				origin.clone(),
+				id.clone().into(),
+				T::Lookup::unlookup(admin.clone()),
+				min_balance,
+			)?;
+			let creator = ensure_signed(origin)?;
+			Self::deposit_event(Event::Create { id, creator, admin });
+			Ok(())
 		}
 
 		/// Start the process of destroying a token with a given asset ID.

pallets/api/src/fungibles/tests.rs

@@ -2,6 +2,7 @@ use crate::{fungibles::Read::*, mock::*};
 use codec::Encode;
 use frame_support::{
 	assert_ok,
+	sp_runtime::traits::Zero,
 	traits::fungibles::{
 		approvals::Inspect as ApprovalInspect, metadata::Inspect as MetadataInspect, Inspect,
 	},
@@ -132,10 +133,13 @@ fn decrease_allowance_works() {
 fn create_works() {
 	new_test_ext().execute_with(|| {
 		let id = ASSET;
+		let creator = ALICE;
+		let admin = ALICE;
 
 		assert!(!Assets::asset_exists(id));
-		assert_ok!(Fungibles::create(signed(ALICE), id, ALICE, 100));
+		assert_ok!(Fungibles::create(signed(creator), id, admin, 100));
 		assert!(Assets::asset_exists(id));
+		System::assert_last_event(Event::Create { id, creator, admin }.into());
 	});
 }
 
@@ -178,9 +182,9 @@ fn clear_metadata_works() {
 
 		create_asset_and_set_metadata(ALICE, id, vec![42], vec![42], 42);
 		assert_ok!(Fungibles::clear_metadata(signed(ALICE), id));
-		assert_eq!(Assets::name(id), Vec::<u8>::new());
-		assert_eq!(Assets::symbol(id), Vec::<u8>::new());
-		assert_eq!(Assets::decimals(id), 0u8);
+		assert!(Assets::name(id).is_empty());
+		assert!(Assets::symbol(id).is_empty());
+		assert!(Assets::decimals(id).is_zero());
 	});
 }