Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add chopsticks config #157

Merged
merged 1 commit into from
Aug 5, 2024

chore: add chopsticks config

8804c57
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

chore: add chopsticks config #157

chore: add chopsticks config
8804c57
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Aug 4, 2024 in 1s

clippy

9 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 9
Note 0
Help 0

Versions

  • rustc 1.80.0 (051478957 2024-07-21)
  • cargo 1.80.0 (376290515 2024-07-16)
  • clippy 0.1.80 (0514789 2024-07-21)

Annotations

Check warning on line 49 in node/src/cli.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> node/src/cli.rs:5:1
   |
5  | / pub enum Subcommand {
6  | |     /// Build a chain specification.
7  | |     BuildSpec(sc_cli::BuildSpecCmd),
...  |
19 | |     ImportBlocks(sc_cli::ImportBlocksCmd),
   | |     ------------------------------------- the second-largest variant contains at least 240 bytes
...  |
39 | |     Benchmark(frame_benchmarking_cli::BenchmarkCmd),
   | |     ----------------------------------------------- the largest variant contains at least 512 bytes
...  |
48 | |     Key(sc_cli::KeySubcommand),
49 | | }
   | |_^ the entire enum is at least 512 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
39 |     Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
   |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 188 in runtime/testnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this match could be replaced by its body itself

warning: this match could be replaced by its body itself
   --> runtime/testnet/src/extensions.rs:186:15
    |
186 |       let result = match key {
    |  __________________^
187 | |         _ => Vec::<u8>::default(),
188 | |     }
    | |_____^ help: consider using the match body instead: `Vec::<u8>::default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
    = note: `#[warn(clippy::match_single_binding)]` on by default

Check warning on line 336 in runtime/testnet/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.

warning: use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.
   --> runtime/testnet/src/lib.rs:336:57
    |
336 |     type OnChargeTransaction = pallet_transaction_payment::CurrencyAdapter<Balances, ()>;
    |                                                            ^^^^^^^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

Check warning on line 33 in runtime/testnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

bound is defined in more than one place

warning: bound is defined in more than one place
  --> runtime/testnet/src/extensions.rs:33:10
   |
33 |     fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
   |             ^
34 |     where
35 |         E: Ext<T = T>,
   |         ^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
   = note: `#[warn(clippy::multiple_bound_locations)]` on by default

Check warning on line 188 in runtime/devnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this match could be replaced by its body itself

warning: this match could be replaced by its body itself
   --> runtime/devnet/src/extensions.rs:186:15
    |
186 |       let result = match key {
    |  __________________^
187 | |         _ => Vec::<u8>::default(),
188 | |     }
    | |_____^ help: consider using the match body instead: `Vec::<u8>::default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
    = note: `#[warn(clippy::match_single_binding)]` on by default

Check warning on line 337 in runtime/devnet/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.

warning: use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.
   --> runtime/devnet/src/lib.rs:337:57
    |
337 |     type OnChargeTransaction = pallet_transaction_payment::CurrencyAdapter<Balances, ()>;
    |                                                            ^^^^^^^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

Check warning on line 33 in runtime/devnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

bound is defined in more than one place

warning: bound is defined in more than one place
  --> runtime/devnet/src/extensions.rs:33:10
   |
33 |     fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
   |             ^
34 |     where
35 |         E: Ext<T = T>,
   |         ^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
   = note: `#[warn(clippy::multiple_bound_locations)]` on by default

Check warning on line 122 in scripts/fund-dev-accounts/./main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> scripts/fund-dev-accounts/./main.rs:122:47
    |
122 |         let query = pop::storage().system().account(&account.public_key().0.into());
    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `account.public_key().0.into()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

Check warning on line 59 in scripts/fund-dev-accounts/./main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used a field initializer for a tuple struct

warning: used a field initializer for a tuple struct
  --> scripts/fund-dev-accounts/./main.rs:54:36
   |
54 |           let assets = VersionedAssets::V3(Assets {
   |  __________________________________________^
55 | |             0: vec![Asset {
56 | |                 id: Concrete(Location { parents: 0, interior: Junctions::Here }),
57 | |                 fun: amount,
58 | |             }],
59 | |         });
   | |_________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
   = note: `#[warn(clippy::init_numbered_fields)]` on by default
help: try
   |
54 ~         let assets = VersionedAssets::V3(Assets(vec![Asset {
55 ~                 id: Concrete(Location { parents: 0, interior: Junctions::Here }),
56 ~                 fun: amount,
57 ~             }]));
   |