Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testnet): activate async backing #172

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

evilrobot-01
Copy link
Collaborator

Enables async backing on the testnet runtime and also ensures that the experimental feature is enabled by adjusting the feature flags. See individual commits for more details.

Closes #170

Simplifies definition of experimental feature, ensuring that it is enabled and defined in a single place. This feature is removed from pallet_aura in https://github.com/paritytech/polkadot-sdk/blob/master/prdoc/1.10.0/pr_3654.prdoc
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.60%. Comparing base (bd47069) to head (61f4c94).

@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   10.60%   10.60%           
=======================================
  Files          27       27           
  Lines        2132     2132           
  Branches     2132     2132           
=======================================
  Hits          226      226           
  Misses       1906     1906           
Files Coverage Δ
runtime/common/src/lib.rs 0.00% <ø> (ø)
runtime/devnet/src/lib.rs 14.88% <ø> (ø)
runtime/testnet/src/lib.rs 14.88% <ø> (ø)

Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@evilrobot-01
Copy link
Collaborator Author

LGTM!

Did you test both runtimes work locally?

@Daanvdplas
Copy link
Collaborator

Yes

Copy link
Collaborator

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Both runtimes work great 🏎️

@Daanvdplas Daanvdplas merged commit a9de17d into main Aug 13, 2024
8 checks passed
@Daanvdplas Daanvdplas deleted the frank/testnet-async-backing branch August 13, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(testnet): async backing
4 participants