Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: error #191

Closed
wants to merge 43 commits into from
Closed

refactor: error #191

wants to merge 43 commits into from

Conversation

Daanvdplas
Copy link
Collaborator

No description provided.

Daanvdplas and others added 30 commits May 19, 2024 17:38
@Daanvdplas
feat: pallet assets pop api integration
7c2eac2
@Daanvdplas
style: renaming assets example
418aa63
@Daanvdplas
refactor: chain extension tests
3d385df
@Daanvdplas
fix: add error handling other than ModuleError
fd46a27
@Daanvdplas
test: add transfer
1022926
@Daanvdplas
chore: remove polkadot launch
ecc82e2
@Daanvdplas
# This is a combination of 8 commits.
e81f78a 
# This is the 1st commit message:

refactor: general

# This is the commit message #2:

init

# This is the commit message #3:

begin refactor

# This is the commit message #4:

refactor: error handling

# This is the commit message #5:

tests: add error handling tests

# This is the commit message #6:

WIP

# This is the commit message #7:

finalise error handling

# This is the commit message #8:

refactor: easier review
@Daanvdplas
refactor: error handling
f824801
@Daanvdplas
refactor: clarify todos
4670503
@Daanvdplas
refactor: error handling comments part 1
2283161
@Daanvdplas
refactor: apply comments part 2
f88dd89
@Daanvdplas
refactor: tests local fungibles
61b3a17
@Daanvdplas
refactor: naming pallet error
c1616a3
@Daanvdplas
refactor: optimising pop api and additional logic + test
13e947e
@Daanvdplas
refactor: runtime
7757319
@Daanvdplas
refactor: draft final design
924df85
@Daanvdplas
feat: add more interfaces
972e4c9
@Daanvdplas
refactor: final bits
47e2ea6
@Daanvdplas
fix: compiling
9dcfccb
@Daanvdplas
fix: cannot find macro vec error
b067eda
@Daanvdplas
refactor: decoding failed and commenting out unimplemented tests
8730f90
@Daanvdplas
style: renaming
b591222
@Daanvdplas
refactor: bits and pieces
c2acbb5
@Daanvdplas
docs: add docs to code
3639320
@Daanvdplas
fix: replace test code to api fungibles
81e9844
@Daanvdplas
fix: own review + fixing CI fail
023d3dc
@Daanvdplas
refactor: add Error variants index + clippy allowance
e683e16
@Daanvdplas @evilrobot-01
feat: api fungibles pallet (#113)
28d971b 
Co-authored-by: Frank Bell <frank@r0gue.io>
@chungquantin
refactor: streamline error from the decoded method by returning `Resu…
4e4512e 
…lt` (#130)
@Daanvdplas
merge main
02dffc6
chungquantin and others added 13 commits July 26, 2024 19:16
@chungquantin @Daanvdplas
refactor: build chain extension method (#121)
027cb85 
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
Co-authored-by: Daanvdplas <daanvdplas@live.nl>
@chungquantin
fix: clean up imports (#135)
30ff91a
@Daanvdplas @evilrobot-01
refactor: remove read state encoding (#122)
9820e7f 
Co-authored-by: Frank Bell <frank@r0gue.io>
@chungquantin @Daanvdplas
feat: transfer_from and decrease_allowance (#134)
5ac5a9a 
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
@Daanvdplas @evilrobot-01
refactor: api integration tests (#133)
d8ac5bd 
Co-authored-by: Frank Bell <frank@r0gue.io>
@chungquantin
refactor: remove bare_call code duplication in integration test (#168)
00c5903
@Daanvdplas
merge main
1acbd21
@Daanvdplas
fix: compilation
9ebe162
@Daanvdplas
fix: try-runtime error
545bd33
@chungquantin
refactor: generic extension crate to de-duplicate code between runtim…
99d0f6d 
…es (#163)
@Daanvdplas @evilrobot-01
feat: api events (#153)
8b4f595 
Co-authored-by: Frank Bell <frank@r0gue.io>
@Daanvdplas
docs: pop api
d271257
@Daanvdplas
refactor: error
645d715
@Daanvdplas Daanvdplas closed this Aug 14, 2024
@Daanvdplas Daanvdplas mentioned this pull request Aug 14, 2024
Merged
19 tasks
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.83864% with 211 lines in your changes missing coverage. Please review.

Project coverage is 31.95%. Comparing base (a9de17d) to head (645d715).

Files Patch % Lines
extension/src/lib.rs 8.00% 138 Missing ⚠️
pallets/api/src/fungibles/mod.rs 82.46% 9 Missing and 18 partials ⚠️
pallets/api/src/fungibles/weights.rs 50.00% 16 Missing ⚠️
runtime/devnet/src/config/api.rs 0.00% 15 Missing ⚠️
extension/src/tests.rs 88.03% 0 Missing and 14 partials ⚠️
runtime/testnet/src/extensions.rs 0.00% 1 Missing ⚠️ 
@@             Coverage Diff             @@
##             main     #191       +/-   ##
===========================================
+ Coverage   10.60%   31.95%   +21.35%     
===========================================
  Files          27       33        +6     
  Lines        2132     2898      +766     
  Branches     2132     2898      +766     
===========================================
+ Hits          226      926      +700     
- Misses       1906     1940       +34     
- Partials        0       32       +32
Files Coverage Δ
extension/src/v0.rs 100.00% <100.00%> (ø)
pallets/api/src/fungibles/benchmarking.rs 100.00% <100.00%> (ø)
pallets/api/src/fungibles/tests.rs 100.00% <100.00%> (ø)
pallets/api/src/mock.rs 100.00% <100.00%> (ø)
runtime/devnet/src/config/contracts.rs 60.00% <ø> (ø)
runtime/devnet/src/config/proxy.rs 0.00% <ø> (ø)
runtime/devnet/src/lib.rs 17.31% <100.00%> (+2.42%) ⬆️
runtime/testnet/src/config/proxy.rs 0.00% <ø> (ø)
runtime/testnet/src/extensions.rs 0.00% <0.00%> (ø)
extension/src/tests.rs 88.03% <88.03%> (ø)
... and 4 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daanvdplas @codecov-commenter @chungquantin