-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devnet): add ismp #270
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #270 +/- ##
==========================================
- Coverage 52.22% 51.47% -0.76%
==========================================
Files 47 48 +1
Lines 4823 4894 +71
Branches 4823 4894 +71
==========================================
Hits 2519 2519
- Misses 2255 2326 +71
Partials 49 49
|
[sc-151] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but my preference would be to not merge in the demo stuff, but rather separate it out into a branch/draft PR which can be used for any testing required and as an easy reference for our own implementation.
To document here, the demo pallet was removed from this PR. Testing ISMP can utilize the following branch (which will never be merged into main). #293 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last tweak please - by adding the mentioned pallet into the benchmarks list now we should hopefully not miss it when progressing to testnet, provided we do a simple diff of the runtimes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very exciting! Left one comment but no reason to wait with merging
This PR adds ISMP to the devnet runtime. The purpose is to get ISMP added to devnet to start deeper work to interface ISMP with contracts, and create more comprehensive testing.
It includes:
Devnet runtime:
Node
Test
Note:
In order to use ISMP, it must be built with
--features ismp
enabled. When this feature is enabled, both testnet and mainnet runtimes will be disabled and error with "ISMP is not enabled". If the feature is not enabled, devnet, testnet, and mainnet will be built. However, ISMP will not work for devnet.Because the node requires that the runtimes implement the runtime API, we must feature-gate with the ISMP feature. Unfortunately, because trait aliases are experimental (nightly) feature-gating is rather verbose allowing us to remain on stable.
Updated CI PR here: #276