Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: devnet runtime api #274

Merged
merged 22 commits into from
Sep 13, 2024
Merged

Conversation

Daanvdplas
Copy link
Collaborator

@Daanvdplas Daanvdplas commented Sep 10, 2024

Add tests for runtime/devnet/src/api.

Changes AllowBalancesCall from devnet and testnet to nothing (#132 (comment))

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.89%. Comparing base (448cbca) to head (5209c44).
Report is 3 commits behind head on daan/api.

@@             Coverage Diff              @@
##           daan/api     #274      +/-   ##
============================================
+ Coverage     45.92%   48.89%   +2.97%     
============================================
  Files            47       47              
  Lines          4279     4532     +253     
  Branches       4279     4532     +253     
============================================
+ Hits           1965     2216     +251     
- Misses         2252     2254       +2     
  Partials         62       62              
Files with missing lines Coverage Δ
pallets/api/src/fungibles/mod.rs 85.48% <ø> (+2.70%) ⬆️
runtime/devnet/src/config/api/mod.rs 67.44% <100.00%> (+32.14%) ⬆️
runtime/devnet/src/config/api/versioning.rs 90.60% <100.00%> (+30.60%) ⬆️
runtime/devnet/src/config/contracts.rs 83.33% <100.00%> (+23.33%) ⬆️
runtime/devnet/src/lib.rs 6.44% <100.00%> (ø)
runtime/testnet/src/config/contracts.rs 83.33% <100.00%> (+23.33%) ⬆️
runtime/testnet/src/lib.rs 5.37% <100.00%> (+1.47%) ⬆️

... and 3 files with indirect coverage changes

@Daanvdplas Daanvdplas changed the title test: devnet runtime versioning test: devnet runtime api Sep 11, 2024
Base automatically changed from daan/test-primitives to daan/tests-pallet_api_extension September 12, 2024 13:56
Base automatically changed from daan/tests-pallet_api_extension to daan/refactor_encoding_scheme September 12, 2024 15:16
Base automatically changed from daan/refactor_encoding_scheme to daan/api September 12, 2024 16:51
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, think there are some easy improvements to make to finish this off.

pallets/api/src/fungibles/mod.rs Outdated Show resolved Hide resolved
runtime/devnet/src/config/api/mod.rs Outdated Show resolved Hide resolved
runtime/devnet/src/config/api/mod.rs Outdated Show resolved Hide resolved
runtime/devnet/src/config/api/mod.rs Show resolved Hide resolved
runtime/devnet/src/config/api/versioning.rs Outdated Show resolved Hide resolved
runtime/devnet/src/config/api/versioning.rs Outdated Show resolved Hide resolved
runtime/devnet/src/config/api/versioning.rs Outdated Show resolved Hide resolved
runtime/devnet/src/config/api/versioning.rs Outdated Show resolved Hide resolved
runtime/devnet/src/config/contracts.rs Show resolved Hide resolved
runtime/testnet/src/config/contracts.rs Show resolved Hide resolved
Copy link
Collaborator

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Would be great to refactor the tests a bit!

runtime/devnet/src/config/api/versioning.rs Show resolved Hide resolved
runtime/devnet/src/config/api/versioning.rs Show resolved Hide resolved
runtime/devnet/src/config/api/versioning.rs Outdated Show resolved Hide resolved
@peterwht peterwht merged commit 4b9da05 into daan/api Sep 13, 2024
9 checks passed
@peterwht peterwht deleted the daan/test-devnet_runtime_versioning branch September 13, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants