refactor: api integration tests #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## daan/api #280 +/- ##
=========================================
Coverage 45.92% 45.92%
=========================================
Files 47 47
Lines 4279 4279
Branches 4279 4279
=========================================
Hits 1965 1965
Misses 2252 2252
Partials 62 62 |
chungquantin
requested changes
Sep 12, 2024
peterwht
approved these changes
Sep 12, 2024
| Err(Module { index: 52, error: [16, 0] }), | ||
| ); | ||
| thaw_asset(addr.clone(), asset); | ||
| pallet_assets_thaw(&addr, token); | ||
| // TODO: calling the below with a vector of length `100_000` errors in pallet contracts | ||
| // `OutputBufferTooSmall. Added to security analysis issue #131 to revisit. |
There was a problem hiding this comment.
not sure this is an issue, just means pallet-contracts properly errors with values too large.
There was a problem hiding this comment.
Something to keep in mind though because whenever the developer wants to set metadata and uses a value that is too large. In stead of pallet assets that returns an error it is pallet contracts.
There was a problem hiding this comment.
Would expect that it might fail with out of gas realistically.
evilrobot-01
approved these changes
Sep 13, 2024
| Err(Module { index: 52, error: [16, 0] }), | ||
| ); | ||
| thaw_asset(addr.clone(), asset); | ||
| pallet_assets_thaw(&addr, token); | ||
| // TODO: calling the below with a vector of length `100_000` errors in pallet contracts | ||
| // `OutputBufferTooSmall. Added to security analysis issue #131 to revisit. |
There was a problem hiding this comment.
Would expect that it might fail with out of gas realistically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains all changes coming from comments for
pop-apiin #132 . Please not that in the comments I used #279 (incorrect) and #280. They both count for this PR.Changes include: