Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pallet-api/fungibles): ensure codec indexes #289

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

peterwht
Copy link
Collaborator

No description provided.

Co-authored-by: Daanvdplas <daanvdplas@live.nl>
@peterwht peterwht changed the base branch from main to daan/api September 13, 2024 18:48
@peterwht peterwht mentioned this pull request Sep 13, 2024
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to reduce the verbosity.

pallets/api/src/fungibles/tests.rs Show resolved Hide resolved
pallets/api/src/fungibles/tests.rs Outdated Show resolved Hide resolved
pallets/api/src/fungibles/tests.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more please.

pallets/api/src/fungibles/tests.rs Outdated Show resolved Hide resolved
pallets/api/src/fungibles/tests.rs Outdated Show resolved Hide resolved
pallets/api/src/fungibles/tests.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@evilrobot-01 evilrobot-01 merged commit fe6286a into daan/api Sep 13, 2024
3 of 4 checks passed
@evilrobot-01 evilrobot-01 deleted the peter/test-codec-indexes branch September 13, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants