feat: sponsorships #362
Merged
feat: sponsorships #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alejandro Martinez Andres <11448715+al3mart@users.noreply.github.com>
…-node into al3mart/sub0/feat-sponsored
Closed
al3mart
commented
Oct 31, 2024
| beneficiary: AccountIdOf<T>, | ||
| ) -> DispatchResult { | ||
| let who = ensure_signed(origin)?; | ||
| if <Sponsorships<T>>::take(&who, &beneficiary).is_some() { |
There was a problem hiding this comment.
Original comment at: #351 (comment)
What would happen to the weight here? Is it just lost?
al3mart
commented
Oct 31, 2024
Comment on lines
+62
to
+66
| fn is_contracts_call( | ||
| call: &<T as frame_system::Config>::RuntimeCall, | ||
| ) -> Option<AccountIdOf<T>> { | ||
| match call.is_sub_type() { | ||
| Some(pallet_revive::Call::<T>::call { dest, .. }) => { |
There was a problem hiding this comment.
Original comment from #351 (comment)
Ideally this would be passed in via a generic type parameter which resolves a runtime call to an account id so no tight coupling to revive and configured at runtime level.
No changes required.
AlexD10S
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the PoC for sponsored transactions.
Means to keeps track of sponsorship relations between a sponsor account and a beneficiary account such that sponsors can cover transaction fees for the beneficiaries.
This PoC introduces a simple pallet that maintains sponsorships in a double map
Note that the value stored is of type
Weigthwith the idea that each relation could have different limits for how much a sponsor should cover for its beneficiary. Although, that is not explored in this PoC.Implements two extrinsics to modify said state:
pub fn sponsor_account(origin: OriginFor<T>, beneficiary: T::AccountId) -> DispatchResult {}pub fn remove_sponsorship_for(origin: OriginFor<T>, beneficiary: T::AccountId) -> DispatchResult {}pub fn set_sponsorship_amount( origin: OriginFor<T>, beneficiary: AccountIdOf<T>, new_amount: BalanceOf<T>) -> DispatchResult {}And the struct
SponsoredimplementsSignedExtensionand it is expected to wrap another implementer ofSignedExtensionthat handles the deduction of the relevant transaction fees.Sponsoredimplementation takes care of verifying the sponsorship exists and forwards to the wrapper extension the correct account to deduct fees from.In this PoC the only possible interaction that can be sponsored is a call to a contract.
This pallet is exposed to ink! contracts via pop-api. A contract is included showing how an account can be registered to be sponsor in the example contract "sponsorships":
pop-api/examples/sponsorships/lib.rs.