-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(drink test): assert last event #370
Merged
chungquantin
merged 3 commits into
chungquantin/feat-psp22_example
from
chungquantin/feat-assert_last_event
Nov 5, 2024
Merged
feat(drink test): assert last event #370
chungquantin
merged 3 commits into
chungquantin/feat-psp22_example
from
chungquantin/feat-assert_last_event
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## chungquantin/feat-psp22_example #370 +/- ##
================================================================
Coverage 51.60% 51.60%
================================================================
Files 48 48
Lines 4910 4910
Branches 4910 4910
================================================================
Hits 2534 2534
Misses 2327 2327
Partials 49 49 |
Daanvdplas
reviewed
Nov 4, 2024
Daanvdplas
reviewed
Nov 4, 2024
Daanvdplas
reviewed
Nov 4, 2024
chungquantin
changed the title
feat: assert last event
feat(drink test): assert last event
Nov 4, 2024
Daanvdplas
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice
chungquantin
merged commit Nov 5, 2024
09311d4
into
chungquantin/feat-psp22_example
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to the pop-api crate for the
assert_last_event!
macro in pop-drinkRequire this PR to be merged to
pop-drink/main
: r0gue-io/pop-drink#25Outcome