Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pop-network): remove coretime use case from testnet #59

Merged
merged 2 commits into from
Mar 29, 2024
Merged

refactor(pop-network): remove coretime use case from testnet #59

merged 2 commits into from
Mar 29, 2024

Conversation

al3mart
Copy link
Collaborator

@al3mart al3mart commented Mar 28, 2024

Closes #54

Removes XCM use cases for contracts from testnet runtime.

@peterwht
Copy link
Collaborator

lgtm. Just needs a cargo fmt

@al3mart al3mart requested a review from peterwht March 28, 2024 22:15
@Daanvdplas Daanvdplas self-requested a review March 29, 2024 06:06
evilrobot-01
evilrobot-01 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@evilrobot-01 evilrobot-01 merged commit e3377e8 into main Mar 29, 2024
5 checks passed
@evilrobot-01 evilrobot-01 deleted the al3mart/refactor-testnet-no-coretime branch March 29, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilrobot-01 evilrobot-01 evilrobot-01 approved these changes

@peterwht peterwht peterwht approved these changes

@Daanvdplas Daanvdplas Awaiting requested review from Daanvdplas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: remove coretime use-case from testnet runtime
3 participants
@al3mart @peterwht @evilrobot-01