feat: pallet proxy #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilrobot-01
force-pushed
the
al3mart/feat-pallet-proxy
branch
from
03337df
to
128a460
Compare
|
Rebased after other two listed PRs merged. |
Daanvdplas
approved these changes
Apr 15, 2024
peterwht
approved these changes
Apr 15, 2024
|
This PR introduces ~150 lines of duplicate code, signalling future technical debt. Appreciate not all of it can be refactored away due to different runtime types, but surely at least the Its easy to just duplicate things, but the burden of later maintenance should be considered. |
|
I am happy to address this. @evilrobot-01 based on previous comments my understanding was that most likely we would move away from maintaining different runtimes. Though this should not be a excuse for not having a proper code base today. |
evilrobot-01
approved these changes
Apr 20, 2024
peterwht
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
pallet-proxyto Pop Network runtimes: