Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(release): add macos support #75

Merged
merged 5 commits into from
Apr 20, 2024
Merged

build(release): add macos support #75

merged 5 commits into from
Apr 20, 2024

Conversation

evilrobot-01
Copy link
Collaborator

@evilrobot-01 evilrobot-01 commented Apr 13, 2024

Reworks the release workflow to include macOS binaries (Apple Silicon and x64), along with aarch64 on Linux.

Examples at https://github.com/r0gue-io/pop-node/releases/tag/test, where binary for each release is compressed and labelled using pop-node-(target)(-cpu) convention, making the files much smaller to download and more importantly, all use pop-node once extracted.

@evilrobot-01 evilrobot-01 force-pushed the frank/build-macos branch 3 times, most recently from 8d8bbc1 to d264527 Compare April 13, 2024 22:47
@evilrobot-01 evilrobot-01 marked this pull request as ready for review April 14, 2024 08:27
@evilrobot-01 evilrobot-01 force-pushed the frank/build-macos branch 5 times, most recently from 90c1139 to de285b5 Compare April 14, 2024 13:59
@evilrobot-01 evilrobot-01 force-pushed the frank/build-macos branch 2 times, most recently from 2d461c9 to 85849c9 Compare April 14, 2024 15:04
@al3mart
Copy link
Collaborator

al3mart commented Apr 15, 2024

Note that while I could review the new workflow, I couldn't run the resulting binaries.
It would be great if another person could verify the result is expected

Copy link
Collaborator

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add --features paseo for now 😅

@peterwht peterwht merged commit efbb2ae into main Apr 20, 2024
11 of 16 checks passed
@peterwht peterwht deleted the frank/build-macos branch April 20, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants