Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: naming examples #79

Closed
wants to merge 4 commits into from

apply comments

dd2c836
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

style: naming examples #79

apply comments
dd2c836
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Apr 29, 2024 in 0s

clippy

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.77.2 (25ef9e3d8 2024-04-09)
  • cargo 1.77.2 (e52e36006 2024-03-26)
  • clippy 0.1.77 (25ef9e3 2024-04-09)

Annotations

Check warning on line 54 in scripts/fund-dev-accounts/./main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used a field initializer for a tuple struct

warning: used a field initializer for a tuple struct
  --> scripts/fund-dev-accounts/./main.rs:54:9
   |
54 |                 id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `AssetId(Location { parents: 0, interior: Junctions::Here })`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields

Check warning on line 57 in scripts/fund-dev-accounts/./main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used a field initializer for a tuple struct

warning: used a field initializer for a tuple struct
  --> scripts/fund-dev-accounts/./main.rs:52:36
   |
52 |           let assets = VersionedAssets::V4(Assets {
   |  __________________________________________^
53 | |             0: vec![Asset {
54 | |                 id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
55 | |                 fun: amount,
56 | |             }],
57 | |         });
   | |_________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
   = note: `#[warn(clippy::init_numbered_fields)]` on by default
help: try
   |
52 ~         let assets = VersionedAssets::V4(Assets(<[_]>::into_vec(
53 +             // This rustc_box is not required, but it produces a dramatic improvement in compile
54 +             // time when constructing arrays with many elements.
55 +             #[rustc_box]
56 +             $crate::boxed::Box::new([$($x),+])
57 ~         )));
   |

Check warning on line 49 in node/src/cli.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> node/src/cli.rs:5:1
   |
5  | / pub enum Subcommand {
6  | |     /// Build a chain specification.
7  | |     BuildSpec(sc_cli::BuildSpecCmd),
8  | |
...  |
19 | |     ImportBlocks(sc_cli::ImportBlocksCmd),
   | |     ------------------------------------- the second-largest variant contains at least 240 bytes
...  |
39 | |     Benchmark(frame_benchmarking_cli::BenchmarkCmd),
   | |     ----------------------------------------------- the largest variant contains at least 512 bytes
...  |
48 | |     Key(sc_cli::KeySubcommand),
49 | | }
   | |_^ the entire enum is at least 512 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
39 |     Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
   |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~